mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "Michael Büsch" <m@bues.ch>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies
Date: Wed, 11 Oct 2023 20:44:49 -0700	[thread overview]
Message-ID: <13eeb01a-2f4f-4c8e-b097-6e80d822862b@infradead.org> (raw)
In-Reply-To: <20231010204346.78961fc4@barney>

Hi Michael,

On 10/10/23 11:43, Michael Büsch wrote:
> On Sun, 8 Oct 2023 23:12:49 -0700
> Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> -	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
>> +	depends on PCI=n || SSB_PCICORE_HOSTMODE
> 
> I thought about something like this:
> 
> depends on (SSB_DRIVER_MIPS && PCI=n) || (SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE)
> 
> Would that solve the warning?

Yes, that works as well, although I prefer to express it like this:

 config SSB_EMBEDDED
 	bool
-	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
+	depends on SSB_DRIVER_MIPS
+	depends on PCI=n || SSB_PCICORE_HOSTMODE
 	default y

although if you prefer the way that you have it above,
I'm OK with that also.

Thanks for your help.

-- 
~Randy

  reply	other threads:[~2023-10-12  3:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-07 18:24 Randy Dunlap
2023-10-08  7:35 ` Michael Büsch
2023-10-08 14:08   ` Randy Dunlap
2023-10-09  6:12     ` Randy Dunlap
2023-10-10 18:43       ` Michael Büsch
2023-10-12  3:44         ` Randy Dunlap [this message]
2023-10-12 17:39           ` Michael Büsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13eeb01a-2f4f-4c8e-b097-6e80d822862b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®