From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933371AbbHJVwX (ORCPT ); Mon, 10 Aug 2015 17:52:23 -0400 Received: from smtprelay0059.hostedemail.com ([216.40.44.59]:35270 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933316AbbHJVwV (ORCPT ); Mon, 10 Aug 2015 17:52:21 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:69:355:379:541:800:960:966:973:988:989:1260:1345:1359:1437:1534:1542:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2902:3138:3139:3140:3141:3142:3353:3865:3866:3871:4250:4321:4384:4385:4395:4605:5007:6261:8603:8829:8957:10004:10848:11026:11657:11658:11914:12043:12294:12296:12438:12517:12519:12555:12679:13972:14096:14394:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: word12_4e9032b48441d X-Filterd-Recvd-Size: 3381 From: Joe Perches To: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Marek Belisko , Greg Kroah-Hartman Subject: [PATCH 04/19] staging: ft1000: Remove unnecessary externs Date: Mon, 10 Aug 2015 14:51:19 -0700 Message-Id: <13f0effe886f40ca747e0dfe7383e5c4871ebe4e.1439241825.git.joe@perches.com> X-Mailer: git-send-email 2.1.2 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using 'extern' is not necessary for function prototypes. Miscellanea: o Reflow alignment Signed-off-by: Joe Perches --- drivers/staging/ft1000/ft1000-pcmcia/ft1000.h | 19 +++++++++---------- drivers/staging/ft1000/ft1000-usb/ft1000_usb.h | 4 ++-- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h index 5992670..e1861cf 100644 --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h @@ -42,17 +42,16 @@ struct ft1000_pcmcia { struct pcmcia_device; struct net_device; -extern struct net_device *init_ft1000_card(struct pcmcia_device *link, - void *ft1000_reset); -extern void stop_ft1000_card(struct net_device *dev); -extern int card_download(struct net_device *dev, const u8 *pFileStart, - size_t FileLength); +struct net_device *init_ft1000_card(struct pcmcia_device *link, + void *ft1000_reset); +void stop_ft1000_card(struct net_device *dev); +int card_download(struct net_device *dev, const u8 *pFileStart, + size_t FileLength); -extern u16 ft1000_read_dpram(struct net_device *dev, int offset); -extern void card_bootload(struct net_device *dev); -extern u16 ft1000_read_dpram_mag_16(struct net_device *dev, int offset, - int Index); -extern u32 ft1000_read_dpram_mag_32(struct net_device *dev, int offset); +u16 ft1000_read_dpram(struct net_device *dev, int offset); +void card_bootload(struct net_device *dev); +u16 ft1000_read_dpram_mag_16(struct net_device *dev, int offset, int Index); +u32 ft1000_read_dpram_mag_32(struct net_device *dev, int offset); void ft1000_write_dpram_mag_32(struct net_device *dev, int offset, u32 value); /* Read the value of a given ASIC register. */ diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.h b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.h index fea60d5..9b5050f 100644 --- a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.h +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.h @@ -134,8 +134,8 @@ extern spinlock_t free_buff_lock; int ft1000_create_dev(struct ft1000_usb *dev); void ft1000_destroy_dev(struct net_device *dev); -extern int card_send_command(struct ft1000_usb *ft1000dev, - void *ptempbuffer, int size); +int card_send_command(struct ft1000_usb *ft1000dev, + void *ptempbuffer, int size); struct dpram_blk *ft1000_get_buffer(struct list_head *bufflist); void ft1000_free_buffer(struct dpram_blk *pdpram_blk, struct list_head *plist); -- 2.1.2