mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Pawel Laszczak <pawell@cadence.com>, peter.chen@nxp.com
Cc: a-govindraju@ti.com, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	kurahul@cadence.com, geert@linux-m68k.org
Subject: Re: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove
Date: Wed, 13 Jan 2021 09:52:30 -0800	[thread overview]
Message-ID: <13f338f1-9ba9-c848-0b75-10e73e8c6a7d@infradead.org> (raw)
In-Reply-To: <20210113141407.25473-1-pawell@cadence.com>

On 1/13/21 6:14 AM, Pawel Laszczak wrote:
> Patch fixes the following errors:
> ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_remove':
> cdnsp-pci.c:(.text+0x80): undefined reference to `cdns_remove'
> ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_probe':
> cdnsp-pci.c:(.text+0x34c): undefined reference to `cdns_init'
> 
> Issue occurs for USB/CDNS3/CDNSP kernel configuration:
> CONFIG_USB=m
> CONFIG_USB_CDNS_SUPPORT=y
> CONFIG_USB_CDNS3=m
> CONFIG_USB_CDNS3_PCI_WRAP=m
> CONFIG_USB_CDNSP_PCI=y
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>

After removing the v1 patch and applying this one, my build errors are gone.
Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> changelog:
> v2
> - added missing condition
> 
>  drivers/usb/cdns3/Makefile | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile
> index 3f9b7fa8a594..61edb2f89276 100644
> --- a/drivers/usb/cdns3/Makefile
> +++ b/drivers/usb/cdns3/Makefile
> @@ -26,7 +26,15 @@ obj-$(CONFIG_USB_CDNS3_TI)			+= cdns3-ti.o
>  obj-$(CONFIG_USB_CDNS3_IMX)			+= cdns3-imx.o
>  
>  cdnsp-udc-pci-y					:= cdnsp-pci.o
> +
> +ifdef CONFIG_USB_CDNSP_PCI
> +ifeq ($(CONFIG_USB),m)
> +obj-m						+= cdnsp-udc-pci.o
> +else
>  obj-$(CONFIG_USB_CDNSP_PCI) 			+= cdnsp-udc-pci.o
> +endif
> +endif
> +
>  cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET)	+= cdnsp-ring.o cdnsp-gadget.o \
>  						   cdnsp-mem.o cdnsp-ep0.o
>  
> 


-- 
~Randy
You can't do anything without having to do something else first.
-- Belefant's Law

  parent reply	other threads:[~2021-01-13 17:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 14:14 Pawel Laszczak
2021-01-13 14:37 ` Pawel Laszczak
2021-01-13 17:52 ` Randy Dunlap [this message]
2021-01-14  1:04   ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13f338f1-9ba9-c848-0b75-10e73e8c6a7d@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=a-govindraju@ti.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kurahul@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pawell@cadence.com \
    --cc=peter.chen@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®