From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 597703C3456 for ; Thu, 23 Apr 2026 09:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776937958; cv=none; b=TwkNPiVaN8quByels9pKWMvwUlO/3LJrTieIHLTEmwfRRMicUAcdIAvXaTnq8P6o1JX5+kOT3BwoSUT675SnvQKRrnz5I2MtAYX2gWOSqgSo6fXWxwFqSEYyXDqi8IRLiQLOoPc8XjUbASTYsMmA29QP5a6COOUHwBzicuvfVt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776937958; c=relaxed/simple; bh=aghY0mkvOIX5kWMQxuTBdzCX8oTd7j2m+sIN2P2xveA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k3zW73QnHlBJ8U5FBE4GQBTs0Yl3kqSjPDNSe07BamzPHv5azYVbcvA/J7LKFOeBji+L8tuAscbiJGQZrtYYYU1et2gpSGVB2ujhq6X+or4Sjmmc7QJi55/lIxCnyQCXl9ax0B1Q34vvh/Rcw+NI3P/lCSKLVpjyUANPnfIFZ18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HONcNDMy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ErMUMcoJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HONcNDMy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ErMUMcoJ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uY2H3413636 for ; Thu, 23 Apr 2026 09:52:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iRbyqna0R9V5j2eqn0kZFVeAKLMYFNPMB99FPVqZ3KE=; b=HONcNDMya+Pusp2E knzZ+LiIc4G4qMCv4YAJzQpg+I3EUtrjnuz8/oCzk4jkwI+DcagqStjmOEr0PPyd oacCf9CsrhbrogCEiJnRuzAhrvcdLtie2v/Vw7p8W6uGcLsFULSb+Ppuune8K2Gf kQeYBJELnVqaR+R8RXvfZjVBR+riHL1Xt1A2yGqy7UD80L+TVvNaQ3zPNONWjNSb xHWE43T+eVx8eT/Bau+6r/OUgqZ8iTPGLF9CeAerH7IVf9roW1KVJ5FpFaU+pXor 2OoWoOpwlYo7UGUatjO74AnLyky1suWb/+SSwvRlrsDzphCNqCPehBj0j6RjRoh1 wb/3HQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1h6bac6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 09:52:29 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b2e6ee9444so72341875ad.1 for ; Thu, 23 Apr 2026 02:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776937949; x=1777542749; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iRbyqna0R9V5j2eqn0kZFVeAKLMYFNPMB99FPVqZ3KE=; b=ErMUMcoJyNvQfg1DVDQahNCHdXLVWhYfMHoSMR7kVT8xJ7Trol5aB3cvj8pEdbd+yc lvsvHU+NZOGBBXUAGCX6vJxAoUMv7WwBdjZaaI03H4tAkz/atB/E2cXERm+gxjnP3OFk zO1oJAcXRCJS97vwLs/8juleQSzzQw7QIVV+TrMu4N7rgoxA1752Cmg4AU+kcPBq+hWt pLhJQZACXYpUw0KeachYtccRbls0KeDuaMKA+x9oSOgzUMViHhVFoYRdvY+JGzZx6sdo 0BIXcbw79xbPOtbnlTgP4I2/ZXf9iPWzzyDvAnwhV5I+f8HxZRvQ0j19heWu8lMb91r0 1r9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776937949; x=1777542749; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iRbyqna0R9V5j2eqn0kZFVeAKLMYFNPMB99FPVqZ3KE=; b=fR5LQMIGRuf/pGmCIC2MHbAabQ7i5IWB10X4oTjYCgeBflfLUwjb5m1+cAoR4RCZGA u19I1Aex2qquPGIAo4bVu9DY+9NW0HAZ27dHWnJRnPlNrCeUjLSHgXoXTZs5I0NJA5gL x78rXOO2bQC/AhmQQVuHp8EXjt6Wu3k80+ym42atTgJaxpLN12V5y+UJfkCPeDmPODDt lVeeazuFuaszOuuPk+/GcfGDv4cYSd89QscUxohzyPH1fd5pgDcsCx5rhv6lNHLXVcRn NThDkcr5ZZfoT4oM+As1+TkXM7unUVlqTeRWXg+BPumnv2MRHxew0DaZa9nkGII6Oedd efBw== X-Forwarded-Encrypted: i=1; AFNElJ+ahj8XhPlWoA3sklnuaXY6P0hLJw+TFX9vmOXqi8wheVWOluBOcYp/YTTQTwuvAxcUQhbY9VtosZZlbic=@vger.kernel.org X-Gm-Message-State: AOJu0YwhBeGKnakaSsDn2ywAQ0pR4k0o0jFcauRSF6CLi52pPC7AHp85 5ORCGbhJLjlkYauBeIjD9hoIpygXq3J9fhQLGtV44n+x2NHGWcINtlWmkq7B2YwjO03Agf/juw1 lnfqVuUgMtvkRb8l0wJj9KZPIquR1b9yHDX9VGkQ9HAXEPS8AGS7AYImDI/ZfjtXUSe8= X-Gm-Gg: AeBDietllYdj95/V/mRYfCyl0x099gDhTLiJczoH99owdTQF2OHV6sNP5jWANa5OWeJ HL0HI8vZ4GXBz98DUp5WunNd1cJryPjXOO9ENcx8CR/E2uAdIWnd70i+GDigeHG6Ip1TLca5wXv MgbIbeba48XuI+3JRD5421FgcnrM6deaRhVH/QU0IV+Gl8EN5zF9BUiWxiWsk3nhsE7BLl1JMOk bT+9azwzNpBjUn8ZXchl7rfgpL3J891wdh32h8JqpE0NdlZ+YBtd0dv0n7/jXt9C/TKfalhtMNa xt0an1d8EH51T8H/hD4lJormIM5jgW+hVYdvsWfHol5jBaIelvbIahYhW3Fh0khgno0e89pm0x+ Er8oNaSZQ7gr3eqVpx+N02+QEhlvBjntPufus9AI5hLqg1cCnIcuzkKEwG4MNnMGH X-Received: by 2002:a17:903:b8e:b0:2b0:b258:2a57 with SMTP id d9443c01a7336-2b5f9ef72bbmr214763485ad.27.1776937948580; Thu, 23 Apr 2026 02:52:28 -0700 (PDT) X-Received: by 2002:a17:903:b8e:b0:2b0:b258:2a57 with SMTP id d9443c01a7336-2b5f9ef72bbmr214763235ad.27.1776937948120; Thu, 23 Apr 2026 02:52:28 -0700 (PDT) Received: from [10.0.0.4] ([106.222.228.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9ff3a8sm178288885ad.12.2026.04.23.02.52.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 02:52:27 -0700 (PDT) Message-ID: <13f370b9-5f0b-ec97-845e-78a5d6bf9a51@oss.qualcomm.com> Date: Thu, 23 Apr 2026 15:22:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 4/7] media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() Content-Language: en-US To: Bryan O'Donoghue , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> <20260422-iris-code-improvement-v1-4-8e150482212d@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=f4Z4wuyM c=1 sm=1 tr=0 ts=69e9ebdd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=rP2ZPG2H70Gfrv7XvIldxw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=l2JAHVFpHO9TSst1FPsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDA5NiBTYWx0ZWRfX9nBQDMT/kgQN b8yDrDPsv8+Rs6xBAp8gb/G8YKqur490iPaCUHC1pQjFVJ0iYnBNm9w9ahM69DG4vxS99IrIdj0 lZAyA4ZFK6bCh5T/SfWzRZyIJ/gCEblETnjBVVdxsQ3Dr2s/5IqP9wGN8YaqEbDuFh9dyj2za3v HpMXti2lPTS/K21Bjy2GEHXMBbnZ/wdeKHoa7KTbuxVB3RRLaA6b6MhjiqPsGEk3l6csGoBX0Mg ouLDHcof7kxUE7llEqvbVD81flbSHhhDKGDKwZPpMuUDY8y5zFQUTRl1pK1QM6ahWgjvd55l5Fy nS+QJnEUSL7JenDVfZBNkhMD94E0cCcBtkt0CmUyh8GcgEIJw4zWGRydE/g/C8DqOrsk/xo1w4g PcIIDkk6CvD+e+/y1e/OTRLAhGZezn0o+uy1w8Zf08w9ojsSmziXnqhpB7hF3zs3YGv9mnfZCD+ 0NgCEHwY2YqKjhZb7aA== X-Proofpoint-GUID: Eq3SYt8TaebkaWJvOA6fr7MIlibykep5 X-Proofpoint-ORIG-GUID: Eq3SYt8TaebkaWJvOA6fr7MIlibykep5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 suspectscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230096 On 4/23/2026 2:55 PM, Bryan O'Donoghue wrote: > On 22/04/2026 12:16, Dikshita Agarwal wrote: >> Fold the ternary initialiser directly into the variable declaration, >> removing the dead store that was immediately overwritten. >> >> Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform >> capabilities and properties") >> Signed-off-by: Dikshita Agarwal >> --- >>   drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 5 ++--- >>   1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c >> b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c >> index >> 30bfd90d423ba024caf6ececc827f7102e8f3324..06698fde639ec654ff9ec78a178271ab2284f5f0 100644 >> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c >> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c >> @@ -536,10 +536,9 @@ static int iris_hfi_gen2_set_tier(struct iris_inst >> *inst, u32 plane) >>   { >>       u32 port = iris_hfi_gen2_get_port(inst, >> V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE); >>       struct iris_inst_hfi_gen2 *inst_hfi_gen2 = >> to_iris_inst_hfi_gen2(inst); >> -    u32 tier = inst->fw_caps[TIER].value; >> - >> -    tier = (inst->codec == V4L2_PIX_FMT_AV1) ? >> inst->fw_caps[TIER_AV1].value : >> +    u32 tier = (inst->codec == V4L2_PIX_FMT_AV1) ? >> inst->fw_caps[TIER_AV1].value : >>                               inst->fw_caps[TIER].value; >> + >>       inst_hfi_gen2->src_subcr_params.tier = tier; >> >>       return iris_hfi_gen2_session_set_property(inst, >> >> -- >> 2.34.1 >> > > I don't get it. > > What's the bug ? It's not a bug, just removing the dead assignment. Will remove fixes tag. Thanks, Dikshita > > --- > bod