From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC6F43C7AE for ; Wed, 29 Jul 2026 09:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785315940; cv=none; b=DauxFt4ZZ6PeIDscK6SZ6dIshv7z8APqsjtYjOKzoM4xMuPgi7WeDsNvZTeyNOZFRTgnHbYw8GZaXN0dbPV9VkaZ2iB7Fmu+olvXChN+7yR3fMNjtRfhpFH0klgFQrFSmvhlWiyzvfYUBIT3P70HmDmIfyhJNcDNrmV6uHe3a+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785315940; c=relaxed/simple; bh=QNikqTvqVkGmUhXpmuK6j1Gvqf1bluFLLOGjK2Nisf0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aTdk32t1INqtDIX27phoxjN/kOP7/eQXaWq67a7JGFPaKVgJYGc7sZ3JqshvZOtvkOnsoBIs/bzTNuLew+HMR7OHU2Ffqvsu5nS2sih3nXUXlqRztr6ddvGoCZux6Qk1fTvzHzGTdELK6FlPq07XjF7Mp/fA1GxQIqaGiQcXXUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ny90bndp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XjZ6Lkdy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ny90bndp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XjZ6Lkdy" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66T7fAN41569286 for ; Wed, 29 Jul 2026 09:05:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VBOrrFUaJtsfvmkvZqyRp/Ke0BbDoZomzwSefP6ue+w=; b=ny90bndpXhALLEDO In86EzGjmP7l9+McPk22Q2xuhWQzTd8PCXBGct4xLC0BYWPhzzNTEe7Gb69P0a5S OJLgqvFWWqGrug8+bNYJFV6l6MGTT0ew8cAhyETof7/Iny1x7vt5wUWHTLVTBy6K E4MmRu1UvIKjdlx95CgPJbk7R8Ur89bnKUUiju7OHn2c1qISELz51PYC7Dxi1nKz 7zXklqx274lgX+Oqzsa09GbjhmA77z6cvXKpYN7/ZBH4go+U9R28GkKwJN7TIuqV 5zgA6CZGoUze7AUjHIlae0y0xdeu2x48rjH1QlVTQq56c9xpGn6K5ROMinFesisH cNtBNw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fq108u4gp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 09:05:38 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cc640dfde3so9328865ad.1 for ; Wed, 29 Jul 2026 02:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785315937; x=1785920737; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=VBOrrFUaJtsfvmkvZqyRp/Ke0BbDoZomzwSefP6ue+w=; b=XjZ6Lkdyrx45ZP3A5FxkPeA47KB/A8S9UOJw2hJq/lJ0NnjEcJLkPsl/eLM9EWmit7 usJOhmnRCbyN/hjUagqbn81Zex2B43+hmEXJt9/O8Kq5paWbJ1k0M0sBXkYjbQ2JATFN 8SzUjnowM/bjgWIZ+dfMOxXJUoVlwSOChHmYZOv7N7JZZhn24ywqTD0g9SUqC2DMLmeZ 9WpA8g44aw9JOve5AAxmy2jP0d1eNEMLr76IqSyT76qPCiQugqGBI7NZK7ysBSK/y9tt m3GpMjDKqdvO6W9lpCWjgzyq5b6u/IAw+XVtSdeHFT2j+X0en0MNMOewQh2FAAJDvPzX 7Dng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785315937; x=1785920737; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VBOrrFUaJtsfvmkvZqyRp/Ke0BbDoZomzwSefP6ue+w=; b=KyX1GU0TuPLW/cJPPrRZunrpKXevFyssMHupgCmXaSmy1cpVnFynlIvYbLOK3/NrUb b3GUzmvTQOxN7ou8q2j0w5HQpSnSM3Na6ZdsJ/kJT64OAjLWNzJwxhA7HVREk/GWq7e7 q+KLt+lmi352Ph/WZBD5wjeWDCNCucJxOf1WqQbA2e3VFxUHTI1cKAQPhfbPS93sg7Sq 4L3G9c/brVFZxIRkXxr3RPrewCIfwbxfq8Ws9SXJx6Obdk0Rednv4CVc+2fBHJB5UxF+ Dyd4PihKwqyIldBLnDAX6Bm90g80Yp3MzdpZScVGVqBQdvpevSgzBI8WT0xjVslA2f3C 1W/Q== X-Forwarded-Encrypted: i=1; AHgh+RoPGcfZRYaC25whzI99kZzIqFDKJSc1QtRpFoXCzQmbzZwrdw+IDwKxPhG7OwE8RdIjx5605/rt0V+5/xU=@vger.kernel.org X-Gm-Message-State: AOJu0YxMCHfY7cu/oZOOWh8gHo8zCwQLjYPbGWK4+7ROkqhtxdh96PmZ V+Xfe4+lGpqp9uRZKnjkFAdVotYAPBQlB9T64xZ20sJv7TjgV85Ah6w2+wOHql5BqT/bbOs6AX4 mQT9ZtIbB2FzpI8z2SMgweh71z5QeYVvrTDLYmBC2oo4tBGURnXQAaL0ShfphYm7lqmU= X-Gm-Gg: AR+sD13ZnwIroIZgjjsNhVIylw8M3BD9750CCxY2z/kXVvsXXqfzwy5iJgo0bG2L/KP u8p+olZ79/vzEjBHuotk/PIASWUt7dowF8ASC+K/SgQYzTBWYGp9vt99DO9fQwXvxXV7uPIDZPU 8OeEjwfvow8zQLMgV8SYHwew5GQAi4plq0lz1Iyk1J8kjOrQ18jbROIGsypCXHCR/xnjcyCwDFC e6RL41Ej/Kt8wmt12y9umKVVCAJlcw77agCGWauSYaes3S5h6xF2F7YlgZVEFbUNenGeAdXPkb0 TRCEN/0DcALjBvK+/AcD4nowfuEeTtwR1WUgimmG8pYOq3rItIzxemIXg8uxQRYf7y7eV3hvFLF QCr1PuJGSJbYzwTCCyRow+S4wCkz9eeXA23v8xGrSMoLlh5ZnFWnSJFxwqlU4vxKL8NG5Lobi8A == X-Received: by 2002:a17:903:1aeb:b0:2ca:be8:62d with SMTP id d9443c01a7336-2d015d26298mr69152755ad.32.1785315937497; Wed, 29 Jul 2026 02:05:37 -0700 (PDT) X-Received: by 2002:a17:903:1aeb:b0:2ca:be8:62d with SMTP id d9443c01a7336-2d015d26298mr69152335ad.32.1785315936912; Wed, 29 Jul 2026 02:05:36 -0700 (PDT) Received: from [10.133.33.108] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022a1586esm8247835ad.12.2026.07.29.02.05.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 02:05:36 -0700 (PDT) Message-ID: <13f6c903-e85a-4f3a-9c96-ffab95f831a2@oss.qualcomm.com> Date: Wed, 29 Jul 2026 17:05:33 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next] wifi: ath11k: fix leak in ath11k_service_ready_ext_event() To: Jeff Johnson , Jeff Johnson Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260727-ath11k_service_ready_ext_event-memleak-v1-1-e8373d27bdd1@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260727-ath11k_service_ready_ext_event-memleak-v1-1-e8373d27bdd1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: VUa9hMkD4yMfo_wwWTz7S5OiFnEWn2RO X-Authority-Analysis: v=2.4 cv=fufsol4f c=1 sm=1 tr=0 ts=6a69c262 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=aNtGKDg7WqoNcE6Ki84A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: VUa9hMkD4yMfo_wwWTz7S5OiFnEWn2RO X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDA3MyBTYWx0ZWRfX9TgNJp7xf37l tw5TGNKYTSNZvUHCDtW+R8+F9bSrI9J4VcirsFpsK8zYWytd0YeFzbAGhA1QBnWDEs4MONINnJ3 l95TPELVULRLvvVdWuoNhPYS/7Qompo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDA3MyBTYWx0ZWRfX8VtFSkLRfIE/ cNmkUt9YMrlHKMEPT7hX5RdpMx1kblO/n2WjzFkLlQXTp/kQSNCDF1npEDJAUlbRs5AcVfB/gkF gS3HbN+tZPS1iBUiBfFE4Fc5XsmnGFaUwFVo8B4rwy6LcKvY/0fD9bBGe9U3JFR+38ADQiuUo5K HSImR0wIjBR0kT1wElZvRAm0XdG3pySTishixeZ/E7epDsHEgw3bNnIRa6uLcNbK0Ve7rDwbA4p fJvS75E06/KLEYKWwG71CA9DTmwbXoOZaDdUFJ7UUaS6hefscKJCbCyGNeGbqn3/cqBgxH0iLMj wJXjsGLRGhLecIlwvP8+P64HnMz231HpLSHQEWphe08sGNHfl4YlWubh7Zp9b2wuuvfW+pSteTo WTWTDCPVlg1USNwS58eWl5AuKFpjHIkuZgnj6K6qTiwOEes+DkbsXB1KwFUlyWOM4bafjNopNWC kRa5543up8vhsQSgFNw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_03,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290073 On 7/28/2026 7:39 AM, Jeff Johnson wrote: > Currently, during ath11k_service_ready_ext_event() processing, > svc_rdy_ext.mac_phy_caps can be allocated during TLV parsing. This is a > temporary allocation that is freed on the success path, but not on the > error path. If parsing succeeds far enough to allocate mac_phy_caps and > then fails on a later TLV, the allocation leaks. So free the allocation > on the error path. > > Compile tested only. > > Fixes: 5b90fc760db5 ("ath11k: fix wmi service ready ext tlv parsing") > Assisted-by: Claude:claude-sonnet-4-6 > Signed-off-by: Jeff Johnson Reviewed-by: Baochen Qiang