From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FA9C145B0B; Mon, 16 Sep 2024 22:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726526032; cv=none; b=CLgFR7M3NhX25nU5+WzI/BLdNlRnAnSAublLjsNhGo95nYUDdoKRCeCCFu6wBBZdu8Pfj1BTWa52e6Ux0QYXzujF7I/Ql3/vbrty0TvzeUpmNGw8GjPOlFzBEquyuIwZe+6gduU41sfJnnnNkocHMIhMYRAMEjQGpYxNYoy7lTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726526032; c=relaxed/simple; bh=xwUhSDBgYfoBQM+Pg/KQwed/s6pcoyBV65jeCuuSuQ4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=u/yhIZwV4dwljlkXM1sTacY8siUv+z0514/rOYXuqBzwrZdgkZw60Kl1xZ1oLOEL9DvvzTMQ4z6YKWHkVc1LZhlY3O2JXNuAjJfsMxBp8TSu16yYF0C/8ownX3gmjiplCYYTlHbM1c5iwlxYhbotadMYCCc2c55kvVhn67rUc50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=WAXGtdTe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="WAXGtdTe" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48GEjbli010095; Mon, 16 Sep 2024 22:33:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jRQmS8uxgnbiobE0eClg3TQPkamskuwaAUNyzBVoJZI=; b=WAXGtdTeH+cZzt0s iO1bpKx1LlJZXdcPCZd3FzkPGfkjtM6grfIvFGE/KG4dX8F+x8YRLpdi5vTduUUA TPXw5pOwZ1B/r7q5pZqqYqAtBQ2jeCmLgQ+2iEg0oXTJCxiKF1HI+wvW7uYGIYv7 pNvR/SIf91nSpIRUxDYsEIpf/BmCz6FIRyreyxFUEzA6/Q+tYDQ2E2VK0Yzn4B+W zbl8O8sHOmkLJ78z8/VS28oD0G+aZIsj1C5dgniznddNr5IQamoeqZcUoMqWJcMh whCiuIWgVdnOYn0oUes823kEZVP3MMoKf1eVu6S9A87IN4AiH++KsAyc4aWN49V1 46/AaA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41n4hh5ayr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Sep 2024 22:33:44 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 48GMXgsg014450 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Sep 2024 22:33:42 GMT Received: from [10.110.75.131] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 16 Sep 2024 15:33:42 -0700 Message-ID: <13f79bfe-a67a-475c-9c1f-dbff802242eb@quicinc.com> Date: Mon, 16 Sep 2024 15:33:36 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next] drm/msm: Remove unneeded semicolon To: Yang Li , , , CC: , , , , Abaci Robot References: <20240903005655.4183-1-yang.lee@linux.alibaba.com> Content-Language: en-US From: Abhinav Kumar In-Reply-To: <20240903005655.4183-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ldKj-MgSZdv3ahSQ8ulZKztzpJzJ3Jr9 X-Proofpoint-ORIG-GUID: ldKj-MgSZdv3ahSQ8ulZKztzpJzJ3Jr9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 clxscore=1011 mlxlogscore=993 mlxscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409160153 On 9/2/2024 5:56 PM, Yang Li wrote: > ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852 > Signed-off-by: Yang Li > --- > drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Change looks fine but can you pls have a short one line in the commit text instead of just pasting the error from the errorchecker? > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > index 0e3a2b16a2ce..65cf237c6b4e 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c > @@ -279,7 +279,7 @@ static int pll_get_post_div(struct hdmi_8998_post_divider *pd, u64 bclk) > case 25: > found_hsclk_divsel = 14; > break; > - }; > + } > > pd->vco_freq = found_vco_freq; > pd->tx_band_sel = found_tx_band_sel;