From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-243.mta1.migadu.com [95.215.58.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50893529412 for ; Tue, 8 Sep 2026 13:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.243 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788875477; cv=none; b=rtSQBQAvnKhjvZOd97DtdxfgVebhwOA5RMvXhydjqMWGOz3tq59KFFK/nkJiY7fF353deu2ZZB8ux3df3UMqZS9ynVUpynK0YsTXOABhONEZjkxudI+Iz2t/CaNOsD85C0PP6Pp8+EQaGNTXmK4Y1/gDqdjQ+VbLftbDMy8xNCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788875477; c=relaxed/simple; bh=yAkATAbOR8BHFyRFOsELRt+fYAiuqFYEVcejaIN9a/4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rmGn8HLVrd+5KPK8QbX8tQRZ5Or0M20XOAvDP3zvRZka0jkMBoQn35ZqfB/6Id5go7RNxN2yNOKLz5BeDdeijeqIlZHEJEjmWY5XHR1sen6AXAY02R3eDyVes0VjG00S1PTelEdQ6u5TpcmE3dHBwOjx1+EgEeIcqhaLJngEjS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=oPb63NSV; arc=none smtp.client-ip=95.215.58.243 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="oPb63NSV" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=yAkATAbOR8BHFyRFOsELRt+fYAiuqFYEVcejaIN9a/4=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788875468; v=1; x=1789480268; b=oPb63NSVAM1cGM61r3OUh0VWBaMubfLs+kPoSFk9e7+oGzj0ePEgc9bgB4asCYi5sHCcAaRP NWU8SJVHohPq/gjzQJUeOcCbNOIBmYtjjS1THrf3uAfm1tPHWli2HKeC0gJ2P3EHcJW3c6I9wGm 3jlBD3YJb4AtNxO//+Wiblz4= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 73574c6019326117; Tue, 08 Sep 2026 13:51:08 +0000 X-Mizu-Trace-ID: 73574c6019326117 X-Migadu-Flow: FLOW_OUT Message-ID: <13fefc5b-7148-48aa-95a6-7f64cf7c66d5@linux.dev> Date: Tue, 8 Sep 2026 21:50:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] selftests/mm: init page sizes early in pagemap_ioctl test To: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, shuah@kernel.org, gourry@gourry.net References: <20260908134117.84405-1-zenghui.yu@linux.dev> <20260908134405.84448-1-zenghui.yu@linux.dev> Content-Language: en-US From: Zenghui Yu In-Reply-To: <20260908134405.84448-1-zenghui.yu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/8/26 9:44 PM, Zenghui Yu wrote: > From: "Zenghui Yu (Huawei)" > > Initialize page_size and hpage_size before calling init_uffd(), > hugetlb_setup_default(), etc. That won't fix anything, but it is safer and > saner to get these globals set up before doing other things. > > While at it, drop the page_size parameter of transact_test(), which is > actually unnecessary. > > Suggested-by: Andrew Morton See https://lore.kernel.org/20260628111329.9cfcd9c67925869307020aba@linux-foundation.org/ . > Signed-off-by: Zenghui Yu (Huawei) > --- > tools/testing/selftests/mm/pagemap_ioctl.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c > index 1a87b7483316..d9a4fb782ecf 100644 > --- a/tools/testing/selftests/mm/pagemap_ioctl.c > +++ b/tools/testing/selftests/mm/pagemap_ioctl.c > @@ -1489,7 +1489,7 @@ static void *thread_proc(void *mem) > return NULL; > } > > -static void transact_test(int page_size) > +static void transact_test(void) > { > unsigned int i, count, extra_pages; > unsigned int c; > @@ -1653,6 +1653,9 @@ int main(int __attribute__((unused)) argc, char *argv[]) > > ksft_print_header(); > > + page_size = getpagesize(); > + hpage_size = read_pmd_pagesize(); > + > if (init_uffd()) > ksft_exit_skip("Failed to initialize userfaultfd\n"); > > @@ -1661,9 +1664,6 @@ int main(int __attribute__((unused)) argc, char *argv[]) > > ksft_set_plan(119); > > - page_size = getpagesize(); > - hpage_size = read_pmd_pagesize(); > - > pagemap_fd = open(PAGEMAP, O_RDONLY); > if (pagemap_fd < 0) > ksft_exit_fail_msg("Failed to open " PAGEMAP "\n"); > @@ -1823,7 +1823,7 @@ int main(int __attribute__((unused)) argc, char *argv[]) > mprotect_tests(); > > /* 13. Transact test */ > - transact_test(page_size); > + transact_test(); > > /* 14. Sanity testing */ > sanity_tests();