mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: "Vinod Koul" <vinod.koul@intel.com>,
	"Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] dmaengine: edma: Reject slave configs using a buswidth of 8 and larger
Date: Thu, 21 Sep 2017 21:29:27 +0300	[thread overview]
Message-ID: <13ff5f5c-3872-4af5-1baf-205fe01bb0f2@ti.com> (raw)
In-Reply-To: <20170921171743.GI30097@localhost>




Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 2017-09-21 20:17, Vinod Koul wrote:
> On Sun, Sep 17, 2017 at 04:25:10PM +0200, Stefan Brüns wrote:
>> The driver would happily accept buswidth of 16/32/64 bytes and program
>> garbage to its registers.
> 
> Peter?

Well, eDMA as such has no limitation on the buswidth, the addr_width
become ACNT, counter for the inner loop - which we use to represent the
word length. In theory we could support 32K-1 long word with eDMA, which
we actually do in case of memcpy.

But the driver does state that it supports bus width of 1, 2, 3 and 4 bytes.

These are form the past and I never felt the need to check them.

I think it is fine to reject salve config when asking for longer dev
width. I might revisit later if the need comes..

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
>>
>> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
>> ---
>>  drivers/dma/edma.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
>> index 3879f80a4815..c944ea339425 100644
>> --- a/drivers/dma/edma.c
>> +++ b/drivers/dma/edma.c
>> @@ -887,8 +887,8 @@ static int edma_slave_config(struct dma_chan *chan,
>>  {
>>  	struct edma_chan *echan = to_edma_chan(chan);
>>  
>> -	if (cfg->src_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES ||
>> -	    cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES)
>> +	if (cfg->src_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES ||
>> +	    cfg->dst_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES)
>>  		return -EINVAL;
>>  
>>  	memcpy(&echan->cfg, cfg, sizeof(echan->cfg));
>> -- 
>> 2.14.1
>>
> 

- Péter

  reply	other threads:[~2017-09-21 18:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17 14:25 Stefan Brüns
2017-09-21 17:17 ` Vinod Koul
2017-09-21 18:29   ` Peter Ujfalusi [this message]
2017-09-22  6:16     ` Peter Ujfalusi
2017-09-22  8:43       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13ff5f5c-3872-4af5-1baf-205fe01bb0f2@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan.bruens@rwth-aachen.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®