From: Mateusz Guzik <mguzik@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, Josef Bacik <jbacik@fb.com>,
Jan Kara <jack@suse.cz>, Al Viro <viro@ZenIV.linux.org.uk>,
Eric Sandeen <esandeen@redhat.com>
Subject: [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems
Date: Tue, 13 May 2014 20:31:02 +0200 [thread overview]
Message-ID: <1400005862-3751-2-git-send-email-mguzik@redhat.com> (raw)
In-Reply-To: <1400005862-3751-1-git-send-email-mguzik@redhat.com>
This helps hang troubleshooting efforts when only dmesg is available.
Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
Cc: linux-fsdevel@vger.kernel.org
Cc: Josef Bacik <jbacik@fb.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Eric Sandeen <esandeen@redhat.com>
---
fs/super.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index 017e10a..581c008 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1289,12 +1289,9 @@ int freeze_super(struct super_block *sb)
return 0; /* sic - it's "nothing to do" */
}
- if (sb->s_flags & MS_RDONLY) {
+ if (sb->s_flags & MS_RDONLY)
/* Nothing to do really... */
- sb->s_writers.frozen = SB_FREEZE_COMPLETE;
- up_write(&sb->s_umount);
- return 0;
- }
+ goto out;
/* From now on, no new normal writers can start */
sb->s_writers.frozen = SB_FREEZE_WRITE;
@@ -1335,8 +1332,10 @@ int freeze_super(struct super_block *sb)
* This is just for debugging purposes so that fs can warn if it
* sees write activity when frozen is set to SB_FREEZE_COMPLETE.
*/
+out:
sb->s_writers.frozen = SB_FREEZE_COMPLETE;
up_write(&sb->s_umount);
+ pr_info("VFS:Filesystem %s thawed\n", sb->s_id);
return 0;
}
EXPORT_SYMBOL(freeze_super);
@@ -1374,7 +1373,7 @@ out:
smp_wmb();
wake_up(&sb->s_writers.wait_unfrozen);
deactivate_locked_super(sb);
-
+ pr_info("VFS:Filesystem %s thawed\n", sb->s_id);
return 0;
}
EXPORT_SYMBOL(thaw_super);
--
1.8.3.1
next prev parent reply other threads:[~2014-05-13 18:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 18:31 [PATCH 1/2] fs: include device name in error messages about freezing Mateusz Guzik
2014-05-13 18:31 ` Mateusz Guzik [this message]
2014-05-13 18:39 ` [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems Joe Perches
2014-05-13 18:53 ` Mateusz Guzik
2014-05-13 19:00 ` Joe Perches
2014-05-13 19:06 ` Mateusz Guzik
2014-05-14 21:54 ` Dave Chinner
2014-05-15 2:17 ` Theodore Ts'o
2014-05-15 3:04 ` Dave Chinner
2014-05-15 9:42 ` Mateusz Guzik
2014-05-15 10:01 ` Jan Kara
2014-05-15 10:43 ` Lukáš Czerner
2014-05-15 12:47 ` Theodore Ts'o
2014-05-15 13:46 ` Jan Kara
2014-05-15 14:15 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400005862-3751-2-git-send-email-mguzik@redhat.com \
--to=mguzik@redhat.com \
--cc=esandeen@redhat.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®