From: Joe Perches <joe@perches.com>
To: Jan Harkes <jaharkes@cs.cmu.edu>
Cc: Fabian Frederick <fabf@skynet.be>,
linux-kernel <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] FS/CODA: replace printk by pr_foo()
Date: Tue, 13 May 2014 12:13:12 -0700 [thread overview]
Message-ID: <1400008392.24350.52.camel@joe-AO725> (raw)
In-Reply-To: <20140513181629.GA24191@cs.cmu.edu>
On Tue, 2014-05-13 at 14:16 -0400, Jan Harkes wrote:
> On Tue, May 13, 2014 at 06:49:09PM +0200, Fabian Frederick wrote:
> > No level printk converted to pr_warn or pr_info
> >
> > Cc: Jan Harkes <jaharkes@cs.cmu.edu>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> > ---
>
> Ack, those are nice cleanups for those ugly printk's. Looks like it will
> shave off a few KB of memory too by making the strings shorter.
No. It doesn't really.
pr_fmt prefaces the format strings with the same
content so there's no actual reduction.
One year soon, I could submit a patch that adds
a generic mechanism to printk which would get the
module name (and function name too) from kallsyms
when pr_fmt is #defined as
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
and it's actually compiled as a module.
That would reduce the format string lengths.
prev parent reply other threads:[~2014-05-13 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 16:49 Fabian Frederick
2014-05-13 18:16 ` Jan Harkes
2014-05-13 19:13 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400008392.24350.52.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®