From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: dormando <dormando@rydia.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Multitude of dst obsolescense race conditions
Date: Wed, 14 May 2014 06:35:23 -0700 [thread overview]
Message-ID: <1400074523.15916.117311749.3590532D@webmail.messagingengine.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1405140233210.16893@dtop>
On Wed, May 14, 2014, at 2:57, dormando wrote:
> Given a machine with frequently changing routes (ie; a router with an
> active internet BGP table and multiple interfaces), there're at least
> several places where obsolete dst's are handled improperly. If I pause
> the
> route changes, the crashes appear to stop. This first one has a crash
> utility we've made, so I was able to more quickly find a patch and test
> it. The others take time to reproduce.
>
> I'm testing against 3.10.39, but I think if these were fixed they'd be
> backported to stable? I've also had recent 3.12's running that have
> crashed in the same spots. Anyway correct me if I'm wrong...
Just a hunch:
You use macvlan? Could you somehow try without?
Maybe... some ref overflow? (You could add some testing code in dst_hold
with atomic_inc_return and WARN_ON).
dst_release already contains such a check, so I am not sure at all if
that could happen.
Bye,
Hannes
next prev parent reply other threads:[~2014-05-14 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 9:57 dormando
2014-05-14 11:40 ` Eric Dumazet
2014-05-14 17:59 ` dormando
2014-06-06 18:12 ` Paul E. McKenney
2014-06-06 18:57 ` Eric Dumazet
2014-06-06 22:17 ` Paul E. McKenney
2014-05-14 13:35 ` Hannes Frederic Sowa [this message]
2014-05-14 18:01 ` dormando
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400074523.15916.117311749.3590532D@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=dormando@rydia.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome