From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: [PATCH v6 01/17] usb: ehci-orion: use platform_get_irq() for DT probing
Date: Thu, 15 May 2014 12:17:26 +0200 [thread overview]
Message-ID: <1400149062-32661-2-git-send-email-gregory.clement@free-electrons.com> (raw)
In-Reply-To: <1400149062-32661-1-git-send-email-gregory.clement@free-electrons.com>
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Commit 77dae54ab385033e488d8b07045bc7f8d931740f ('ARM: Kirkwood:
ehci-orion: Add device tree binding') added the Device Tree binding
for the ehci-orion driver. To achieve that with the irq, it used the
irq_of_parse_and_map() function when probed in DT-mode, and
platform_get_irq() when probed in non-DT mode.
This is not necessary: platform_get_irq() works just as fine in
DT-mode, since the conversion from DT information to 'struct resource'
is done by the generic layers of the kernel.
Therefore, this commit switches back to use just platform_get_irq().
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
drivers/usb/host/ehci-orion.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
index 30d35e5e503a..7728e83007a7 100644
--- a/drivers/usb/host/ehci-orion.c
+++ b/drivers/usb/host/ehci-orion.c
@@ -154,10 +154,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
pr_debug("Initializing Orion-SoC USB Host Controller\n");
- if (pdev->dev.of_node)
- irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
- else
- irq = platform_get_irq(pdev, 0);
+ irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
dev_err(&pdev->dev,
"Found HC with no IRQ. Check %s setup!\n",
--
1.8.1.2
next prev parent reply other threads:[~2014-05-15 10:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 10:17 [PATCH v6 00/17] USB support for Armada 38x and Armada 375 Gregory CLEMENT
2014-05-15 10:17 ` Gregory CLEMENT [this message]
2014-05-15 10:17 ` [PATCH v6 02/17] usb: ehci-orion: rename error goto labels in ehci_orion_drv_probe() Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 03/17] usb: ehci-orion: fix clock reference leaking Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 04/17] usb: ehci-orion: add optional PHY support Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 05/17] Documentation: dt-bindings: update ehci-orion binding documentation Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 06/17] usb: host: xhci-plat: sort the headers in alphabetic order Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 07/17] usb: host: xhci-plat: add clock support Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 08/17] usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 09/17] Documentation: dt-bindings: update xhci-platform DT binding Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 10/17] ARM: mvebu: add USB3 support for Armada 38x Gregory CLEMENT
2014-05-16 5:39 ` Jason Cooper
2014-05-16 19:07 ` Jason Cooper
2014-05-19 11:09 ` Paul Bolle
2014-05-21 13:53 ` Gregory CLEMENT
2014-05-22 14:08 ` Jason Cooper
2014-05-15 10:17 ` [PATCH v6 11/17] ARM: mvebu: add USB3 support for Armada 375 Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 12/17] ARM: configs: enable XHCI mvebu support in mvebu_v7_defconfig Gregory CLEMENT
2014-05-16 5:41 ` Jason Cooper
2014-05-16 19:07 ` Jason Cooper
2014-05-15 10:17 ` [PATCH v6 13/17] ARM: configs: enable XHCI mvebu support in multi_v7_defconfig Gregory CLEMENT
2014-05-15 13:32 ` Jason Cooper
2014-05-15 10:17 ` [PATCH v6 14/17] ARM: mvebu: add Device Tree description of xHCI controllers on Armada 38x Gregory CLEMENT
2014-05-16 5:57 ` Jason Cooper
2014-05-16 19:07 ` Jason Cooper
2014-05-15 10:17 ` [PATCH v6 15/17] ARM: mvebu: add Device Tree description of the EHCI controller " Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 16/17] ARM: mvebu: add Device Tree description of the xHCI controller on Armada 375 Gregory CLEMENT
2014-05-15 10:17 ` [PATCH v6 17/17] ARM: mvebu: add Device Tree description of the EHCI " Gregory CLEMENT
2014-05-15 13:26 ` Sergei Shtylyov
2014-05-15 13:34 ` Jason Cooper
2014-05-15 13:44 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400149062-32661-2-git-send-email-gregory.clement@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®