From: Stephan Mueller <smueller@chronox.de>
To: David Howells <dhowells@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, linux-security-module@vger.kernel.org,
keyrings@vger.kernel.org
Subject: Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace
Date: Wed, 27 Jul 2016 13:21:48 +0200 [thread overview]
Message-ID: <14001554.0xCMXCgYeT@tauon.atsec.com> (raw)
In-Reply-To: <146961615805.14395.5581949237156769439.stgit@warthog.procyon.org.uk>
Am Mittwoch, 27. Juli 2016, 11:42:38 CEST schrieb David Howells:
Hi David,
> x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than
> calling sys_keyctl. The latter will work in a lot of cases, thereby hiding
> the issue.
>
> Reported-by: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: Stephan Mueller <smueller@chronox.de>
> cc: stable@vger.kernel.org
> ---
>
> arch/x86/entry/syscalls/syscall_32.tbl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl
> b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17153fb..f848572169ea
> 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -294,7 +294,7 @@
> # 285 sys_setaltroot
> 286 i386 add_key sys_add_key
> 287 i386 request_key sys_request_key
> -288 i386 keyctl sys_keyctl
> +288 i386 keyctl sys_keyctl compat_sys_keyctl
> 289 i386 ioprio_set sys_ioprio_set
> 290 i386 ioprio_get sys_ioprio_get
> 291 i386 inotify_init sys_inotify_init
Ciao
Stephan
next prev parent reply other threads:[~2016-07-27 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 10:42 David Howells
2016-07-27 11:21 ` Stephan Mueller [this message]
2016-08-01 10:37 ` [tip:x86/urgent] x86/syscalls/64: Add " tip-bot for David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14001554.0xCMXCgYeT@tauon.atsec.com \
--to=smueller@chronox.de \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®