From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753612AbaEOM2y (ORCPT ); Thu, 15 May 2014 08:28:54 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:37949 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbaEOM2w (ORCPT ); Thu, 15 May 2014 08:28:52 -0400 From: Ricardo Ribalda Delgado To: balbi@ti.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, joe@perches.com, auttamchandani@logicube.com Cc: Ricardo Ribalda Delgado Subject: [PATCH 1/2 v4] usb: gadget: net2280: Fix NULL pointer dereference Date: Thu, 15 May 2014 14:28:45 +0200 Message-Id: <1400156926-11100-1-git-send-email-ricardo.ribalda@gmail.com> X-Mailer: git-send-email 2.0.0.rc0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When DEBUG is enabled driver->driver.name is accessed, but driver can be NULL [ 174.411689] BUG: unable to handle kernel NULL pointer dereference at 0000000000000040 [ 174.429043] RIP: 0010:[] [] net2280_stop+0xa3/0x100 [net2280] [ 174.457910] Call Trace: [ 174.459503] [] usb_gadget_remove_driver+0x5a/0xb0 [udc_core] [ 174.462693] [] usb_del_gadget_udc+0xb4/0x110 [udc_core] [ 174.464316] [] net2280_remove+0x2f/0x1c0 [net2280] Signed-off-by: Ricardo Ribalda Delgado --- v4: Replace if with terniary operator drivers/usb/gadget/net2280.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index 43e5e2f..300b3a7 100644 --- a/drivers/usb/gadget/net2280.c +++ b/drivers/usb/gadget/net2280.c @@ -1972,7 +1972,9 @@ static int net2280_stop(struct usb_gadget *_gadget, device_remove_file (&dev->pdev->dev, &dev_attr_function); device_remove_file (&dev->pdev->dev, &dev_attr_queues); - DEBUG (dev, "unregistered driver '%s'\n", driver->driver.name); + DEBUG(dev, "unregistered driver '%s'\n", + driver ? driver->driver.name : ""); + return 0; } -- 2.0.0.rc0