From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: jan.kiszka@siemens.com, kvm@vger.kernel.org, gleb@kernel.org,
avi.kivity@gmail.com
Subject: [PATCH v2 2/4] KVM: x86: drop set_rflags callback
Date: Thu, 15 May 2014 18:51:29 +0200 [thread overview]
Message-ID: <1400172691-27030-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1400172691-27030-1-git-send-email-pbonzini@redhat.com>
Not needed anymore now that the CPL is computed directly
by the task switch code.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch/x86/include/asm/kvm_emulate.h | 1 -
arch/x86/kvm/x86.c | 6 ------
2 files changed, 7 deletions(-)
diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h
index 24ec1216596e..a04fe4eb237d 100644
--- a/arch/x86/include/asm/kvm_emulate.h
+++ b/arch/x86/include/asm/kvm_emulate.h
@@ -189,7 +189,6 @@ struct x86_emulate_ops {
void (*set_idt)(struct x86_emulate_ctxt *ctxt, struct desc_ptr *dt);
ulong (*get_cr)(struct x86_emulate_ctxt *ctxt, int cr);
int (*set_cr)(struct x86_emulate_ctxt *ctxt, int cr, ulong val);
- void (*set_rflags)(struct x86_emulate_ctxt *ctxt, ulong val);
int (*cpl)(struct x86_emulate_ctxt *ctxt);
int (*get_dr)(struct x86_emulate_ctxt *ctxt, int dr, ulong *dest);
int (*set_dr)(struct x86_emulate_ctxt *ctxt, int dr, ulong value);
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index fb313fc896dd..57eac309c22e 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4646,11 +4646,6 @@ static int emulator_set_cr(struct x86_emulate_ctxt *ctxt, int cr, ulong val)
return res;
}
-static void emulator_set_rflags(struct x86_emulate_ctxt *ctxt, ulong val)
-{
- kvm_set_rflags(emul_to_vcpu(ctxt), val);
-}
-
static int emulator_get_cpl(struct x86_emulate_ctxt *ctxt)
{
return kvm_x86_ops->get_cpl(emul_to_vcpu(ctxt));
@@ -4835,7 +4830,6 @@ static const struct x86_emulate_ops emulate_ops = {
.set_idt = emulator_set_idt,
.get_cr = emulator_get_cr,
.set_cr = emulator_set_cr,
- .set_rflags = emulator_set_rflags,
.cpl = emulator_get_cpl,
.get_dr = emulator_get_dr,
.set_dr = emulator_set_dr,
--
1.8.3.1
next prev parent reply other threads:[~2014-05-15 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 16:51 [PATCH v2 0/4] KVM: x86: get CPL from SS.DPL Paolo Bonzini
2014-05-15 16:51 ` [PATCH v2 1/4] KVM: x86: use new CS.RPL as CPL during task switch Paolo Bonzini
2014-05-16 22:19 ` Paolo Bonzini
2014-05-26 16:55 ` Marcelo Tosatti
2014-05-15 16:51 ` Paolo Bonzini [this message]
2014-05-15 16:51 ` [PATCH v2 3/4] KVM: x86: check CS.DPL against RPL " Paolo Bonzini
2014-05-26 17:01 ` Marcelo Tosatti
2014-05-15 16:51 ` [PATCH v2 4/4] KVM: x86: get CPL from SS.DPL Paolo Bonzini
2014-05-26 16:10 ` Marcelo Tosatti
[not found] <CALeycy9yGFXcwusztKokfybGUcK+eyCfmSD34+1eG+b88d7J6w@mail.gmail.com>
2014-05-25 23:06 ` [PATCH v2 2/4] KVM: x86: drop set_rflags callback Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400172691-27030-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®