mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <kishon@ti.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 04/11] phy: exynos-mipi-video: fix check on array index
Date: Fri, 16 May 2014 18:32:59 +0530	[thread overview]
Message-ID: <1400245387-14445-5-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1400245387-14445-1-git-send-email-kishon@ti.com>

From: Antoine Ténart <antoine.tenart@free-electrons.com>

The phys array is of size EXYNOS_MIPI_PHYS_NUM. Trying to access the
index EXYNOS_MIPI_PHYS_NUM should return an error.

Fixes: 069d2e26e9d6 "phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs"

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/phy-exynos-mipi-video.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
index 7f13932..ff02668 100644
--- a/drivers/phy/phy-exynos-mipi-video.c
+++ b/drivers/phy/phy-exynos-mipi-video.c
@@ -101,7 +101,7 @@ static struct phy *exynos_mipi_video_phy_xlate(struct device *dev,
 {
 	struct exynos_mipi_video_phy *state = dev_get_drvdata(dev);
 
-	if (WARN_ON(args->args[0] > EXYNOS_MIPI_PHYS_NUM))
+	if (WARN_ON(args->args[0] >= EXYNOS_MIPI_PHYS_NUM))
 		return ERR_PTR(-ENODEV);
 
 	return state->phys[args->args[0]].phy;
-- 
1.7.9.5


  parent reply	other threads:[~2014-05-16 13:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16 13:02 [GIT PULL 00/11] PHY: for 3.16 Kishon Vijay Abraham I
2014-05-16 13:02 ` [PATCH 01/11] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk" Kishon Vijay Abraham I
2014-05-16 13:02 ` [PATCH 02/11] phy: omap-usb2: Add clock names to Documentation binding Kishon Vijay Abraham I
2014-05-16 13:02 ` [PATCH 03/11] PHY: Exynos: fix SATA phy license typo Kishon Vijay Abraham I
2014-05-16 13:02 ` Kishon Vijay Abraham I [this message]
2014-05-16 13:03 ` [PATCH 05/11] phy: kona2: use 'select GENERIC_PHY' in Kconfig Kishon Vijay Abraham I
2014-05-16 13:03 ` [PATCH 06/11] Documentation: Document Exynos5 USB 3.0 DRD PHY Kishon Vijay Abraham I
2014-05-16 13:03 ` [PATCH 07/11] phy: Add new Exynos5 USB 3.0 PHY driver Kishon Vijay Abraham I
2014-05-16 13:03 ` [PATCH 08/11] phy: exynos5-usbdrd: Add facility for VBUS supply Kishon Vijay Abraham I
2014-05-16 13:03 ` [PATCH 09/11] phy: sunxi: Rework phy initialization Kishon Vijay Abraham I
2014-05-16 13:03 ` [PATCH 10/11] Documentation: dt: Add new compatible for the A31 USB Phy Kishon Vijay Abraham I
2014-05-16 13:03 ` [PATCH 11/11] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support Kishon Vijay Abraham I
2014-05-20  0:57 ` [GIT PULL 00/11] PHY: for 3.16 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400245387-14445-5-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®