mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masaru Nomura <massa.nomura@gmail.com>
To: lidza.louina@gmail.com, markh@compro.net
Cc: gregkh@linuxfoundation.org,
	driverdev-devel@linuxdriverproject.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Masaru Nomura <massa.nomura@gmail.com>
Subject: [PATCH 3/4] staging: dgnc: dgnc_neo: Fix conditional part of if statement
Date: Sat, 17 May 2014 17:30:53 +0100	[thread overview]
Message-ID: <1400344254-13007-4-git-send-email-massa.nomura@gmail.com> (raw)
In-Reply-To: <1400344254-13007-1-git-send-email-massa.nomura@gmail.com>

Fix line over 80 characters of if-condition part and also
indent the lines to tell the difference between the condition and
body of the if statement.

Then I think we can keep the readability and meet coding style
with this change.

Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
---
 drivers/staging/dgnc/dgnc_neo.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 8988346..c211f9f 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -838,9 +838,11 @@ static void neo_param(struct tty_struct *tty)
 	 * Have the UART interrupt on modem signal changes ONLY when
 	 * we are in hardware flow control mode, or CLOCAL/FORCEDCD is not set.
 	 */
-	if ((ch->ch_digi.digi_flags & CTSPACE) || (ch->ch_digi.digi_flags & RTSPACE) ||
-		(ch->ch_c_cflag & CRTSCTS) || !(ch->ch_digi.digi_flags & DIGI_FORCEDCD) ||
-		!(ch->ch_c_cflag & CLOCAL)) {
+	if ((ch->ch_digi.digi_flags & CTSPACE)
+			|| (ch->ch_digi.digi_flags & RTSPACE)
+			|| (ch->ch_c_cflag & CRTSCTS)
+			|| !(ch->ch_digi.digi_flags & DIGI_FORCEDCD)
+			|| !(ch->ch_c_cflag & CLOCAL)) {
 		ier |= UART_IER_MSI;
 	} else {
 		ier &= ~UART_IER_MSI;
-- 
1.7.9.5


  parent reply	other threads:[~2014-05-17 16:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-17 16:30 [PATCH 0/4] Fix coding style " Masaru Nomura
2014-05-17 16:30 ` [PATCH 1/4] staging: dgnc: Fix indenting of if-else statement Masaru Nomura
2014-05-17 16:30 ` [PATCH 2/4] staging: dgnc: dgnc_neo: Fix indenting of if statement Masaru Nomura
2014-05-17 16:30 ` Masaru Nomura [this message]
2014-05-17 19:39   ` [PATCH 3/4] staging: dgnc: dgnc_neo: Fix conditional part " Dan Carpenter
2014-05-17 21:14     ` Masaru Nomura
2014-05-17 21:23       ` Dan Carpenter
2014-05-17 16:30 ` [PATCH 4/4] staging: dgnc: Remove unnecessary braces Masaru Nomura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400344254-13007-4-git-send-email-massa.nomura@gmail.com \
    --to=massa.nomura@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®