mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: jolsa@redhat.com
Cc: acme@ghostprotocols.net, peterz@infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	namhyung@gmail.com, eranian@google.com,
	Andi Kleen <andi@firstfloor.org>, Don Zickus <dzickus@redhat.com>
Subject: [PATCH 6/7] perf: Add support to dynamically get cacheline size
Date: Mon, 19 May 2014 15:13:52 -0400	[thread overview]
Message-ID: <1400526833-141779-7-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1400526833-141779-1-git-send-email-dzickus@redhat.com>

Different arches may have different cacheline sizes.  Look it up and set
a global variable for reference.

Signed-off-by: Don Zickus <dzickus@redhat.com>
---
 tools/perf/util/cpumap.c | 31 +++++++++++++++++++++++++++++++
 tools/perf/util/cpumap.h | 12 ++++++++++++
 tools/perf/util/sort.c   |  3 +++
 3 files changed, 46 insertions(+)

diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c
index c4e55b7..d833238 100644
--- a/tools/perf/util/cpumap.c
+++ b/tools/perf/util/cpumap.c
@@ -477,3 +477,34 @@ int cpu__setup_cpunode_map(void)
 	closedir(dir1);
 	return 0;
 }
+
+int cpu__setup_cacheline_size(void)
+{
+	const char *mnt;
+	char path[PATH_MAX];
+	int n, ret, size;
+	FILE *fp;
+	
+
+	mnt = sysfs__mountpoint();
+	if (!mnt)
+		return -1;
+
+	n = snprintf(path, PATH_MAX, "%s/devices/system/cpu/cpu0/cache/index0/coherency_line_size", mnt);
+	if (n == PATH_MAX) {
+		pr_err("sysfs path crossed PATH_MAX(%d) size\n", PATH_MAX);
+		return -1;
+	}
+
+	fp = fopen(path, "r");
+	if (!fp)
+		return -1;
+	ret = fscanf(fp, "%d", &size);
+	fclose(fp);
+	if (ret != 1)
+		return -1;
+
+	cacheline_size = size;
+
+	return 0;
+}
diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h
index 61a6548..b3e7b22 100644
--- a/tools/perf/util/cpumap.h
+++ b/tools/perf/util/cpumap.h
@@ -81,4 +81,16 @@ static inline int cpu__get_node(int cpu)
 	return cpunode_map[cpu];
 }
 
+int cacheline_size;
+
+int cpu__setup_cacheline_size(void);
+
+static inline int cpu__cacheline_size(void)
+{
+	if (unlikely(!cacheline_size))
+		pr_debug("cacheline size not initialized\n");
+
+	return cacheline_size;
+}
+
 #endif /* __PERF_CPUMAP_H */
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index 635cd8f..50adbfb 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -2,6 +2,7 @@
 #include "hist.h"
 #include "comm.h"
 #include "symbol.h"
+#include "cpumap.h"
 
 regex_t		parent_regex;
 const char	default_parent_pattern[] = "^sys_|^do_page_fault";
@@ -1117,6 +1118,8 @@ int setup_sorting(void)
 		return -ENOMEM;
 	}
 
+	cpu__setup_cacheline_size();
+
 	for (tok = strtok_r(str, ", ", &tmp);
 			tok; tok = strtok_r(NULL, ", ", &tmp)) {
 		ret = sort_dimension__add(tok);
-- 
1.7.11.7


  parent reply	other threads:[~2014-05-19 19:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 19:13 [PATCH 0/7 V3] x86, nmi: Various fixes and cleanups Don Zickus
2014-05-19 19:13 ` [PATCH 1/7] events, perf: Pass protection and flags bits through mmap2 interface Don Zickus
2014-06-12 12:02   ` [tip:perf/core] " tip-bot for Peter Zijlstra
2014-05-19 19:13 ` [PATCH 2/7] Revert "perf: Disable PERF_RECORD_MMAP2 support" Don Zickus
2014-05-19 19:13 ` [PATCH 3/7] perf: Update mmap2 interface with protection and flag bits Don Zickus
2014-06-12 12:02   ` [tip:perf/core] perf tools: " tip-bot for Don Zickus
2014-05-19 19:13 ` [PATCH 4/7] perf report: Add mem-mode documentation to report command Don Zickus
2014-06-12 12:02   ` [tip:perf/core] " tip-bot for Don Zickus
2014-05-19 19:13 ` [PATCH 5/7] perf: Add cpumode to struct hist_entry Don Zickus
2014-05-19 19:13 ` Don Zickus [this message]
2014-05-23 16:54   ` [PATCH 6/7] perf: Add support to dynamically get cacheline size Jiri Olsa
2014-05-23 17:18     ` Don Zickus
2014-05-23 17:09   ` Jiri Olsa
2014-05-23 17:30     ` Don Zickus
2014-05-19 19:13 ` [PATCH 7/7] perf: Add dcacheline sort Don Zickus
2014-05-23 17:14   ` Jiri Olsa
2014-05-27 16:28 [PATCH 0/7 V4] perf: Enable mmap2 and add dcacheline sorting Don Zickus
2014-05-27 16:28 ` [PATCH 6/7] perf: Add support to dynamically get cacheline size Don Zickus
2014-05-30  7:09   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400526833-141779-7-git-send-email-dzickus@redhat.com \
    --to=dzickus@redhat.com \
    --cc=acme@ghostprotocols.net \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®