Re: [PATCH 1/1] drivers/scsi/tmscsim.c: replace shift loop by ilog2

[Joe Perches <joe@perches.com>]

On Tue, 2014-05-20 at 18:48 +0200, Fabian Frederick wrote:
> Cc: Kurt Garloff <garloff@suse.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  drivers/scsi/tmscsim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
[]
> @@ -1611,7 +1611,7 @@ dc390_Reselect( struct dc390_acb* pACB )
>        printk (KERN_ERR "DC390: Reselection must select host adapter: %02x!\n", lun);
>      else
>        lun ^= 1 << pACB->pScsiHost->this_id; /* Mask AdapterID */
> -    id = 0; while (lun >>= 1) id++;
> +    id = ilog2(lun);
>      /* Get LUN */
>      lun = DC390_read8 (ScsiFifo);
>      if (!(lun & IDENTIFY_BASE)) printk (KERN_ERR "DC390: Resel: Expect identify message!\n");

Hey Fabian.

You've submitted several of these now.

Have you gone through all of these to make sure
that the ilog2(<foo>) uses are always using a
non-zero <foo>?

If so, that should be mentioned in the changelog.

These should probably add #include <linux/log2.h>

It would have been nicer to use a patch series
and a cover letter so I could make this reply to
to cover letter.

Please take the time to setup and use git send-email
instead of sylpheed.