From: Joe Perches <joe@perches.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Jason Low <jason.low2@hp.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Len Brown <len.brown@intel.com>, Russ Anderson <rja@sgi.com>,
Dimitri Sivanich <sivanich@sgi.com>, Hedi Berriche <hedi@sgi.com>,
Andi Kleen <andi@firstfloor.org>,
Michel Lespinasse <walken@google.com>,
Rik van Riel <riel@redhat.com>,
Peter Hurley <peter@hurleysoftware.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Reduce the rate of needless idle load balancing
Date: Tue, 20 May 2014 18:15:53 -0700 [thread overview]
Message-ID: <1400634953.26709.42.camel@joe-AO725> (raw)
In-Reply-To: <1400619878.2970.276.camel@schen9-DESK>
On Tue, 2014-05-20 at 14:04 -0700, Tim Chen wrote:
> On Tue, 2014-05-20 at 13:59 -0700, Tim Chen wrote:
> > On Tue, 2014-05-20 at 13:51 -0700, Jason Low wrote:
> > > On Tue, May 20, 2014 at 1:17 PM, Tim Chen <tim.c.chen@linux.intel.com> wrote:
> > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
[]
> > > If we want to do idle load balancing only when it is due for a
> > > balance, shouldn't the above just be "if (time_after(jiffies,
> > > rq->next_balance))"?
> >
> > If rq->next_balance and jiffies are equal, then
> > time_after(jiffies, rq->next_balance) check will be false and
> > you will not do balance. But actually you want to balance
> > for this case so the jiffies+1 was used.
>
> So maybe I should switch the check to
> if (time_before(rq->next_balance, jiffies))
time_after_eq() or time_is_after_eq_jiffies()
next prev parent reply other threads:[~2014-05-21 1:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 20:17 Tim Chen
2014-05-20 20:51 ` Jason Low
2014-05-20 20:58 ` Rik van Riel
2014-05-20 20:59 ` Tim Chen
2014-05-20 21:04 ` Tim Chen
2014-05-21 1:15 ` Joe Perches [this message]
2014-05-21 16:37 ` Tim Chen
2014-05-21 18:26 ` Davidlohr Bueso
2014-05-21 18:49 ` Tim Chen
2014-05-20 21:09 ` Jason Low
2014-05-20 21:12 ` Tim Chen
2014-05-20 21:39 ` Tim Chen
2014-05-21 6:38 ` Peter Zijlstra
2014-06-05 14:34 ` [tip:sched/core] sched/balancing: " tip-bot for Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400634953.26709.42.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hedi@sgi.com \
--cc=jason.low2@hp.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter@hurleysoftware.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rja@sgi.com \
--cc=sivanich@sgi.com \
--cc=tim.c.chen@linux.intel.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®