From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jim Baxter <jim_baxter@mentor.com>
Cc: David Miller <davem@davemloft.net>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kamal@canonical.com,
bhutchings@solarflare.com, edumazet@google.com, mszeredi@suse.cz,
fw@strlen.de
Subject: Re: skbuff truesize incorrect.
Date: Thu, 22 May 2014 13:30:03 -0700 [thread overview]
Message-ID: <1400790603.5367.167.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <537E5C63.7080607@mentor.com>
On Thu, 2014-05-22 at 21:21 +0100, Jim Baxter wrote:
> OK, so it is the value of the memory that has been allocated for the SKB.
> If there are multiple clones for an skb all pointing at the same data,
> will that distort the memory used when they all have the same truesize?
Its always better to over estimate memory uses, than under estimating.
Its all about guarding against OOM.
Keep in mind some parts of networking stack do not like clones.
TCP coalescing works beautifully with non cloned skbs.
Instead of cloning skb or doing copies, you could play with having frame
on a page fragment. Only headers might need to be pulled from the frame
to linear part of skb.
next prev parent reply other threads:[~2014-05-22 20:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 19:07 Jim Baxter
2014-05-22 19:21 ` David Miller
2014-05-22 20:21 ` Jim Baxter
2014-05-22 20:30 ` Eric Dumazet [this message]
2014-05-22 20:58 ` David Miller
2014-05-23 9:21 ` Jim Baxter
2014-05-23 9:27 ` David Laight
2014-05-23 16:46 ` David Miller
2014-05-22 19:25 ` Vlad Yasevich
2014-05-22 19:39 ` Jim Baxter
2014-05-22 19:59 ` Eric Dumazet
2014-05-22 20:21 ` Jim Baxter
2014-05-22 20:58 ` Eric Dumazet
2014-05-22 21:03 ` Eric Dumazet
2014-05-22 21:10 ` David Miller
2014-05-23 7:07 ` Bjørn Mork
2014-05-23 8:58 ` Jim Baxter
2014-05-23 9:33 ` Bjørn Mork
2014-05-23 14:00 ` Eric Dumazet
2014-05-23 15:44 ` Rick Jones
2014-05-23 16:00 ` Eric Dumazet
2014-05-23 8:52 ` David Laight
2014-05-23 9:48 ` Bjørn Mork
2014-05-23 10:45 ` David Laight
2014-05-23 11:13 ` Jim Baxter
2014-05-23 13:47 ` Eric Dumazet
2014-05-23 15:00 ` Jim Baxter
2014-05-23 15:30 ` David Laight
2014-05-23 15:41 ` Eric Dumazet
2014-05-23 20:18 ` David Miller
2014-05-27 15:23 ` David Laight
2014-05-27 15:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400790603.5367.167.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jim_baxter@mentor.com \
--cc=kamal@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mszeredi@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®