From: Chen Yucong <slaoub@gmail.com>
To: tony.luck@intel.com
Cc: bp@alien8.de, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, Chen Yucong <slaoub@gmail.com>
Subject: [PATCH] x86/mce: Fix incorrect comment in do_machine_check()
Date: Sat, 24 May 2014 10:16:41 +0800 [thread overview]
Message-ID: <1400897801-27370-1-git-send-email-slaoub@gmail.com> (raw)
In do_machine_check function, we can find the following code segment:
* ...
* /* mce_clear_state will clear *final, save locally for use later */
* m = *final;
*
* if (!no_way_out)
* mce_clear_state(toclear);
* ...
But the reality is that mce_clear_state function will not clear *final. It is just
used to clear bank MSRs or the relative field of injectm used by MCE-Injection.
Meanwhile, mce_reign executed by monarch CPU will clear *final, therefore we need
to save it locally for use later.
Signed-off-by: Chen Yucong <slaoub@gmail.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 68317c8..83159c1 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1137,7 +1137,9 @@ void do_machine_check(struct pt_regs *regs, long error_code)
}
}
- /* mce_clear_state will clear *final, save locally for use later */
+ /* mce_reign executed by monarch CPU will clear *final(mces_seen),
+ * save locally for use later
+ */
m = *final;
if (!no_way_out)
--
1.7.10.4
reply other threads:[~2014-05-24 2:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400897801-27370-1-git-send-email-slaoub@gmail.com \
--to=slaoub@gmail.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®