mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Hirokazu Takata <takata@linux-m32r.org>
Cc: linux-pcmcia@lists.infradead.org, linux-m32r@ml.linux-m32r.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] pcmcia: m32r: remove check for CONFIG_M32RPCC_SLOT2
Date: Sat, 24 May 2014 08:26:56 +0200	[thread overview]
Message-ID: <1400912816.31526.73.camel@x220> (raw)

This driver contains a check for CONFIG_M32RPCC_SLOT2 ever since it was
added in v2.6.10 it. But there's no matching Kconfig symbol. Remove
that check. But leave the second call of add_pcc_socket() if-zeroed out.
The code clearly is written to be able handle two sockets. It's just not
clear if it is always safe to do that. Add a comment to clarify this
decision.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.

Pet peeve: the code has module support, but M32R_PCC is bool!

 drivers/pcmcia/m32r_pcc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pcmcia/m32r_pcc.c b/drivers/pcmcia/m32r_pcc.c
index 296514155cd5..a86ada82b61c 100644
--- a/drivers/pcmcia/m32r_pcc.c
+++ b/drivers/pcmcia/m32r_pcc.c
@@ -695,7 +695,7 @@ static int __init init_m32r_pcc(void)
 
 	add_pcc_socket(M32R_PCC0_BASE, PCC0_IRQ, M32R_PCC0_MAPBASE, 0x1000);
 
-#ifdef CONFIG_M32RPCC_SLOT2
+#if 0 /* XXX In what cases is it OK to do this? */
 	add_pcc_socket(M32R_PCC1_BASE, PCC1_IRQ, M32R_PCC1_MAPBASE, 0x2000);
 #endif
 
-- 
1.9.0


                 reply	other threads:[~2014-05-24  6:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400912816.31526.73.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m32r@ml.linux-m32r.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=takata@linux-m32r.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®