From: "Randy.Dunlap" <rddunlap@osdl.org>
To: <inaky.perez-gonzalez@intel.com>
Cc: <acme@conectiva.com.br>, <gh@us.ibm.com>, <rddunlap@osdl.org>,
<devenyga@mcmaster.ca>, <rml@tech9.net>,
<linux-kernel@vger.kernel.org>
Subject: RE: PATCH: Replace current->state with set_current_state in 2.5.6 8
Date: Tue, 6 May 2003 20:20:28 -0700 (PDT) [thread overview]
Message-ID: <1401.4.64.196.31.1052277628.squirrel@www.osdl.org> (raw)
In-Reply-To: <A46BBDB345A7D5118EC90002A5072C780C8FDF0C@orsmsx116.jf.intel.com>
>
>> From: Arnaldo Carvalho de Melo [mailto:acme@conectiva.com.br]
>>
>> > > And I don't really want to review a 176 KB patch (although I did
> already
>> > > look over most of it a few days ago). Do people want to take portions
>> of it for review and then see about Alan merging it, e.g.?
>
> As long as they use set_current_state() and not the __ counterpart, then
> they are ok [the memory barrier being to blame for the lost
> performance if any is found].
Yes, last week at least the patch did use set_current_state() almost
exclusively, even when it didn't need to -- most likely.
>> > Hmm. Has anyone considered a "Kernel Janitor's" tree? More
> specifically,
>> > a patch set, much like -ac or -mm, with the current cleanups so they can
>> be tested, pulled, run through automated batch testing, etc.?
>>
>> That is an interesting idea, I'll probably start one.
Yay!
Thanks, acme.
~Randy
next prev parent reply other threads:[~2003-05-07 3:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-07 2:12 Perez-Gonzalez, Inaky
2003-05-07 3:20 ` Randy.Dunlap [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-05-07 0:33 Perez-Gonzalez, Inaky
2003-05-07 1:24 ` Randy.Dunlap
2003-05-07 2:01 ` Gerrit Huizenga
2003-05-07 2:07 ` Arnaldo Carvalho de Melo
2003-05-07 9:35 ` Paul P Komkoff Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401.4.64.196.31.1052277628.squirrel@www.osdl.org \
--to=rddunlap@osdl.org \
--cc=acme@conectiva.com.br \
--cc=devenyga@mcmaster.ca \
--cc=gh@us.ibm.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®