From: Johannes Berg <johannes@sipsolutions.net>
To: Rostislav Lisovy <lisovy@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Sojka <sojkam1@fel.cvut.cz>,
s.sander@nordsys.de, jan-niklas.meier@volkswagen.de,
Rostislav Lisovy <rostislav.lisovy@fel.cvut.cz>
Subject: Re: [RFC 1/2] cfg80211: Add channel flags limiting availability to OCB mode only
Date: Mon, 26 May 2014 11:35:28 +0200 [thread overview]
Message-ID: <1401096928.19055.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1401095199.11908.6.camel@umadbro> (sfid-20140526_110645_465239_E133F549)
On Mon, 2014-05-26 at 11:06 +0200, Rostislav Lisovy wrote:
> On Mon, 2014-05-19 at 16:51 +0200, Johannes Berg wrote:
> > This patch is fine, but insufficient - you should also do something
> > with
> > the new flags?
>
> That's definitely a good point. I think the biggest issue is that the
> flags can't be checked only with the knowledge of the 'wiphy' but they
> are related to the 'vif' type -- this prohibits checking in the
> cfg80211_chandef_usable() (I assume).
>
> Would the following be sufficient?
Well, you'll find that if you address my comments on the other patch,
all of this discussion goes away easily.
johannes
next prev parent reply other threads:[~2014-05-26 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 14:49 [RFC 0/2] mac80211: Add new interface type for OCB (Outside the Context of a BSS) mode Rostislav Lisovy
2014-05-19 14:49 ` [RFC 1/2] cfg80211: Add channel flags limiting availability to OCB mode only Rostislav Lisovy
2014-05-19 14:51 ` Johannes Berg
2014-05-26 9:06 ` Rostislav Lisovy
2014-05-26 9:35 ` Johannes Berg [this message]
2014-05-19 14:49 ` [RFC 2/2] mac80211: Add new interface type for OCB mode Rostislav Lisovy
2014-05-19 14:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401096928.19055.7.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jan-niklas.meier@volkswagen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lisovy@gmail.com \
--cc=rostislav.lisovy@fel.cvut.cz \
--cc=s.sander@nordsys.de \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®