mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
To: <containers@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Serge Hallyn <serge.hallyn@ubuntu.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	David Howells <dhowells@redhat.com>,
	Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
Subject: [PATCH] /proc/pid/status: show all sets of pid according to ns
Date: Mon, 26 May 2014 18:05:28 +0800	[thread overview]
Message-ID: <1401098728-2001-1-git-send-email-chenhanxiao@cn.fujitsu.com> (raw)

We need a direct method of getting the pid inside containers.
If some issues occurred inside a container guest, host user
could not know which process is in trouble just by guest pid:
the users of container guest only knew the pid inside containers.
This will bring obstacle for trouble shooting.

This patch expands fields of Tgid and Pid:
a) In init_pid_ns, nothing changed;

b) In one pidns, they will tell the pid inside containers:
Tgid:	1628 	9 	3
Pid:	1628 	9 	3
** process id is 1628 in level 0, 9 in level 1, 3 in level 2.

c) If pidns is nested, it depends on which pidns are you in.
Tgid:	9 	3
Pid:	9 	3
** Views from level 1 for Pid 1628 in host.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
---
 fs/proc/array.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/fs/proc/array.c b/fs/proc/array.c
index 64db2bc..eef20dd 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -173,17 +173,23 @@ static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
 	cred = get_task_cred(p);
 	seq_printf(m,
 		"State:\t%s\n"
-		"Tgid:\t%d\n"
-		"Ngid:\t%d\n"
-		"Pid:\t%d\n"
+		"Ngid:\t%d\n",
+		get_task_state(p),
+		task_numa_group_id(p));
+	seq_puts(m, "Tgid:");
+	for (g = ns->level; g <= pid->level; g++)
+		seq_printf(m, "\t%d ",
+		task_tgid_nr_ns(p, pid->numbers[g].ns));
+	seq_puts(m, "\nPid:");
+	for (g = ns->level; g <= pid->level; g++)
+		seq_printf(m, "\t%d ",
+		task_pid_nr_ns(p, pid->numbers[g].ns));
+	seq_putc(m, '\n');
+	seq_printf(m,
 		"PPid:\t%d\n"
 		"TracerPid:\t%d\n"
 		"Uid:\t%d\t%d\t%d\t%d\n"
 		"Gid:\t%d\t%d\t%d\t%d\n",
-		get_task_state(p),
-		task_tgid_nr_ns(p, ns),
-		task_numa_group_id(p),
-		pid_nr_ns(pid, ns),
 		ppid, tpid,
 		from_kuid_munged(user_ns, cred->uid),
 		from_kuid_munged(user_ns, cred->euid),
-- 
1.9.0


             reply	other threads:[~2014-05-26 10:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 10:05 Chen Hanxiao [this message]
2014-05-26 11:09 ` Richard Weinberger
2014-05-27  9:36   ` chenhanxiao
2014-05-26 18:04 ` Vasily Kulikov
2014-05-27 10:01   ` chenhanxiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401098728-2001-1-git-send-email-chenhanxiao@cn.fujitsu.com \
    --to=chenhanxiao@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=berrange@redhat.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=serge.hallyn@ubuntu.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®