From: Joe Perches <joe@perches.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Dominique van den Broeck <domdevlin@free.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: panel: (coding style) Matching braces
Date: Mon, 26 May 2014 10:28:10 -0700 [thread overview]
Message-ID: <1401125290.519.18.camel@joe-AO725> (raw)
In-Reply-To: <20140526142827.GG13929@1wt.eu>
On Mon, 2014-05-26 at 16:28 +0200, Willy Tarreau wrote:
> I believe that most of the kernel code prefers the two-line format resluting
> in this instead :
>
> }
> else if (*esc >= 'A' && *esc <= 'Z') {
> value |= (*esc - 'A' + 10) << shift;
> }
> else if (*esc >= 'a' && *esc <= 'z') {
> value |= (*esc - 'a' + 10) << shift;
> }
> else {
grep shows what kernel style is most used.
Your form:
}
else if (...) {
(This shows 3 lines per instance)
$ grep-2.5.4 -rP --include=*.[ch] '}\n[ \t]*else if.*{\n' * | wc -l
909
Generally used form:
} else if (...) {
(mostly shows 2 lines per instance)
$ grep-2.5.4 -rP --include=*.[ch] '} else if.*{\n' * | wc -l
31653
That's ~50:1 preference for "} else if (...) {"
> It's just a matter of taste I know,
true enough.
next prev parent reply other threads:[~2014-05-26 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 12:09 Dominique van den Broeck
2014-05-21 12:10 ` [PATCH 2/3] staging: panel: (coding style) Line alignments and malloc sizeof Dominique van den Broeck
2014-05-21 12:10 ` [PATCH 3/3] staging: panel: (coding style) Multiple assignments Dominique van den Broeck
2014-05-23 11:33 ` Greg Kroah-Hartman
2014-05-23 23:35 ` [PATCH v2 " Dominique van den Broeck
2014-05-26 14:28 ` [PATCH 1/3] staging: panel: (coding style) Matching braces Willy Tarreau
2014-05-26 14:45 ` Dominique van den Broeck
2014-05-26 15:05 ` Willy Tarreau
2014-05-26 17:28 ` Joe Perches [this message]
2014-05-26 17:49 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401125290.519.18.camel@joe-AO725 \
--to=joe@perches.com \
--cc=domdevlin@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®