From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH v2 1/6] sched/fair.c: remove "power" from struct numa_stats
Date: Tue, 27 May 2014 05:07:08 +0200 [thread overview]
Message-ID: <1401160028.5134.7.camel@marge.simpson.net> (raw)
In-Reply-To: <1401142779-6633-2-git-send-email-nicolas.pitre@linaro.org>
On Mon, 2014-05-26 at 18:19 -0400, Nicolas Pitre wrote:
>
> @@ -1046,7 +1046,7 @@ static void update_numa_stats(struct numa_stats *ns, int nid)
>
> ns->nr_running += rq->nr_running;
> ns->load += weighted_cpuload(cpu);
> - ns->power += power_of(cpu);
> + ns->compute_capacity += power_of(cpu);
power_of(cpu) as a capacity input looks odd now..
> @@ -1062,9 +1062,10 @@ static void update_numa_stats(struct numa_stats *ns, int nid)
> if (!cpus)
> return;
>
> - ns->load = (ns->load * SCHED_POWER_SCALE) / ns->power;
> - ns->capacity = DIV_ROUND_CLOSEST(ns->power, SCHED_POWER_SCALE);
> - ns->has_capacity = (ns->nr_running < ns->capacity);
> + ns->load = (ns->load * SCHED_POWER_SCALE) / ns->compute_capacity;
> + ns->task_capacity =
> + DIV_ROUND_CLOSEST(ns->compute_capacity, SCHED_POWER_SCALE);
..as do SCHED_POWER_SCALE, update_cpu_power() etc.
-Mike
next prev parent reply other threads:[~2014-05-27 3:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 22:19 [PATCH v2 0/6] sched: expel confusing usage of the term "power" Nicolas Pitre
2014-05-26 22:19 ` [PATCH v2 1/6] sched/fair.c: remove "power" from struct numa_stats Nicolas Pitre
2014-05-27 3:07 ` Mike Galbraith [this message]
2014-05-27 3:18 ` Nicolas Pitre
2014-05-27 4:32 ` Mike Galbraith
2014-05-26 22:19 ` [PATCH v2 2/6] sched/fair.c: change "has_capacity" to "has_free_capacity" Nicolas Pitre
2014-05-26 22:19 ` [PATCH v2 3/6] sched/fair.c: disambiguate existing/remaining "capacity" usage Nicolas Pitre
2014-05-26 22:19 ` [PATCH v2 4/6] sched: let struct sched_group_power care about CPU capacity Nicolas Pitre
2014-05-26 22:19 ` [PATCH v2 5/6] sched: remove remaining dubious usage of "power" Nicolas Pitre
2014-05-26 22:19 ` [PATCH v2 6/6] sched: final power vs capacity cleanup Nicolas Pitre
2014-05-27 7:30 ` [PATCH v2 0/6] sched: expel confusing usage of the term "power" Vincent Guittot
2014-05-27 14:46 ` Nicolas Pitre
2014-05-27 14:07 ` Daniel Lezcano
2014-05-27 16:02 ` Nicolas Pitre
2014-05-27 16:14 ` Daniel Lezcano
2014-05-27 17:50 ` [PATCH v2 7/6] sched: rename capacity related flags Nicolas Pitre
2014-05-28 6:46 ` [PATCH v2 0/6] sched: expel confusing usage of the term "power" Peter Zijlstra
2014-06-05 10:09 ` Ingo Molnar
2014-06-05 10:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401160028.5134.7.camel@marge.simpson.net \
--to=umgwanakikbuti@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome