From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: linux-edac <linux-edac@vger.kernel.org>, X86 ML <x86@kernel.org>,
Tony Luck <tony.luck@intel.com>
Subject: [RFC PATCH 3/3] MCE, CE: Add debugging glue
Date: Tue, 27 May 2014 15:27:15 +0200 [thread overview]
Message-ID: <1401197235-13440-4-git-send-email-bp@alien8.de> (raw)
In-Reply-To: <1401197235-13440-1-git-send-email-bp@alien8.de>
From: Borislav Petkov <bp@suse.de>
For testing purposes only.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
arch/x86/kernel/cpu/mcheck/ce.c | 24 ++++++++++++++++++++++++
arch/x86/kernel/cpu/mcheck/mce.c | 31 ++++++++++++++++++++++++++++++-
2 files changed, 54 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mcheck/ce.c b/arch/x86/kernel/cpu/mcheck/ce.c
index 3020415f27f4..aa2fee325588 100644
--- a/arch/x86/kernel/cpu/mcheck/ce.c
+++ b/arch/x86/kernel/cpu/mcheck/ce.c
@@ -94,6 +94,25 @@ static struct ce_array {
static DEFINE_MUTEX(ce_lock);
+static void dump_array(struct ce_array *ca)
+{
+ u64 prev = 0;
+ int i;
+
+ pr_info("{ n: %d\n", ca->n);
+ for (i = 0; i < ca->n; i++) {
+ u64 this = PFN(ca->array[i]);
+
+ pr_info(" %03d: [%016llu|%03llx]\n", i, this, FULL_COUNT(ca->array[i]));
+
+ WARN_ON(prev > this);
+
+ prev = this;
+ }
+
+ pr_info("}\n");
+}
+
/*
* Decrement decay value. We're using DECAY_BITS bits to denote decay of an
* element in the array. On insertion and any access, it gets maxed
@@ -202,6 +221,9 @@ u64 ce_del_lru_elem(void)
pfn = PFN(ca->array[min_idx]);
+ pr_err("%s: Deleting ca[%d]: %016llu|%03x\n",
+ __func__, min_idx, pfn, min);
+
__del_elem(ca, min_idx);
mutex_unlock(&ce_lock);
@@ -263,7 +285,9 @@ int ce_add_elem(u64 pfn)
ret = 0;
}
+
unlock:
+ dump_array(ca);
mutex_unlock(&ce_lock);
return ret;
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 732fbe61416d..59b726d4e116 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2552,9 +2552,34 @@ static int fake_panic_set(void *data, u64 val)
DEFINE_SIMPLE_ATTRIBUTE(fake_panic_fops, fake_panic_get,
fake_panic_set, "%llu\n");
+static u64 cec_pfn;
+
+static int cec_pfn_get(void *data, u64 *val)
+{
+ *val = cec_pfn;
+ return 0;
+}
+
+static int cec_pfn_set(void *data, u64 val)
+{
+ int ret;
+
+ cec_pfn = val;
+
+ ret = ce_add_elem(val);
+ if (ret < 0) {
+ ce_del_lru_elem();
+ ret = ce_add_elem(val);
+ }
+
+ return ret;
+}
+
+DEFINE_SIMPLE_ATTRIBUTE(cec_pfn_ops, cec_pfn_get, cec_pfn_set, "0x%llx\n");
+
static int __init mcheck_debugfs_init(void)
{
- struct dentry *dmce, *ffake_panic;
+ struct dentry *dmce, *ffake_panic, *cec_pfn;
dmce = mce_get_debugfs_dir();
if (!dmce)
@@ -2564,6 +2589,10 @@ static int __init mcheck_debugfs_init(void)
if (!ffake_panic)
return -ENOMEM;
+ cec_pfn = debugfs_create_file("cec_pfn", 0400, dmce, NULL, &cec_pfn_ops);
+ if (!cec_pfn)
+ return -ENOMEM;
+
return 0;
}
#else
--
1.9.0
next prev parent reply other threads:[~2014-05-27 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 13:27 [RFC PATCH 0/3] RAS: Correctable Errors Collector thing Borislav Petkov
2014-05-27 13:27 ` [RFC PATCH 1/3] MCE, CE: Corrected errors collecting thing Borislav Petkov
2014-05-27 13:27 ` [RFC PATCH 2/3] MCE, CE: Wire in the CE collector Borislav Petkov
2014-05-27 17:48 ` Tony Luck
2014-05-27 18:48 ` Borislav Petkov
2014-05-27 13:27 ` Borislav Petkov [this message]
2014-05-28 2:49 ` [RFC PATCH 0/3] RAS: Correctable Errors Collector thing Chen Yucong
2014-05-28 16:53 ` Max Asbock
2014-05-28 17:21 ` Luck, Tony
2014-05-28 17:23 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401197235-13440-4-git-send-email-bp@alien8.de \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome