From: Dongsu Park <dongsu.park@profitbricks.com>
To: linux-kernel@vger.kernel.org
Cc: Dongsu Park <dongsu.park@profitbricks.com>,
Jens Axboe <axboe@kernel.dk>, Jet Chen <jet.chen@intel.com>,
Maurizio Lombardi <mlombard@redhat.com>
Subject: [PATCH] bio: decrease bi_iter.bi_size by len in the fail path
Date: Wed, 28 May 2014 17:09:38 +0200 [thread overview]
Message-ID: <1401289778-9840-1-git-send-email-dongsu.park@profitbricks.com> (raw)
In-Reply-To: <20140527112459.GF2205@dhcp-27-189.brq.redhat.com>
From: Dongsu Park <dongsu.park@profitbricks.com>
Commit 3979ef4dcf3d1de55a560a3a4016c30a835df44d ("bio-modify-
__bio_add_page-to-accept-pages-that-dont-start-a-new-segment-v3")
introduced a regression as reported by Jet Chen.
That results in a kernel BUG at drivers/block/virtio_blk.c:166.
To fix that, bi_iter.bi_size must be decreased by len, before
recounting the number of physical segments.
Tested on with kernel 3.15.0-rc7-next-20140527 on qemu guest,
by running xfstests/ext4/271.
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Jet Chen <jet.chen@intel.com>
Cc: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Dongsu Park <dongsu.park@profitbricks.com>
---
block/bio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/bio.c b/block/bio.c
index 0443694ccbb4..67d7cba1e5fd 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -810,6 +810,7 @@ static int __bio_add_page(struct request_queue *q, struct bio *bio, struct page
bvec->bv_len = 0;
bvec->bv_offset = 0;
bio->bi_vcnt--;
+ bio->bi_iter.bi_size -= len;
blk_recount_segments(q, bio);
return 0;
}
--
1.9.1
next prev parent reply other threads:[~2014-05-28 15:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 19:43 [jet.chen@intel.com: [bio] kernel BUG at drivers/block/virtio_blk.c:166!] Maurizio Lombardi
2014-05-27 4:03 ` Ming Lei
2014-05-27 8:44 ` Maurizio Lombardi
2014-05-27 11:24 ` Maurizio Lombardi
2014-05-28 15:09 ` Dongsu Park
2014-05-28 15:09 ` Dongsu Park [this message]
2014-05-28 15:42 ` [PATCH] bio: decrease bi_iter.bi_size by len in the fail path Ming Lei
2014-05-28 16:59 ` Ming Lei
2014-05-28 17:21 ` Maurizio Lombardi
2014-05-28 17:44 ` Ming Lei
2014-05-29 6:06 ` Jet Chen
2014-05-29 7:04 ` Maurizio Lombardi
2014-05-29 7:28 ` Ming Lei
2014-05-29 3:35 ` Jet Chen
2014-05-29 4:13 ` Ming Lei
2014-05-29 4:36 ` Jet Chen
2014-05-30 9:41 ` Dongsu Park
2014-05-28 15:49 ` Maurizio Lombardi
2014-05-29 3:21 ` Jet Chen
2014-05-28 15:16 ` [jet.chen@intel.com: [bio] kernel BUG at drivers/block/virtio_blk.c:166!] Jet Chen
2014-05-28 15:27 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401289778-9840-1-git-send-email-dongsu.park@profitbricks.com \
--to=dongsu.park@profitbricks.com \
--cc=axboe@kernel.dk \
--cc=jet.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome