mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Dave Jones <davej@redhat.com>,
	"dirk.brandewie@gmail.com" <dirk.brandewie@gmail.com>
Cc: George Spelvin <linux@horizon.com>,
	herbert@gondor.apana.org.au, james.guilford@intel.com,
	JBeulich@suse.com, linux-kernel@vger.kernel.org,
	Jacob jun Pan <jacob.jun.pan@intel.com>
Subject: Re: [RFC PATCH] crypto: crc32c-pclmul - Use pmovzxdq to shrink K_table
Date: Fri, 30 May 2014 10:56:32 -0700	[thread overview]
Message-ID: <1401472592.2970.483.camel@schen9-DESK> (raw)
In-Reply-To: <20140530011636.GA31694@redhat.com>

On Thu, 2014-05-29 at 21:16 -0400, Dave Jones wrote:
> On Thu, May 29, 2014 at 06:07:16PM -0700, Tim Chen wrote:
>  > On Thu, 2014-05-29 at 19:54 -0400, George Spelvin wrote:
>  > > Sorry for the delay; my Ivy Bridge test machine isn't in my
>  > > office and getting to the console to tweak the BIOS is a
>  > > bit of a bother.
>  > > 
>  > > Anyway, i7-4930K, turbo boost & hyperthreading disabled,
>  > > $ cat /sys/devices/system/cpu/cpu?/cpufreq/scaling_governor
>  > > performance
>  > > performance
>  > > performance
>  > > performance
>  > > performance
>  > > performance
>  > > 
>  > > Oddly, though, CPU speed still seems to be fluctuating:
>  > > $ grep MHz /proc/cpuinfo
>  > > cpu MHz         : 1255.875
>  > > cpu MHz         : 3168.375
>  > > cpu MHz         : 3062.125
>  > > cpu MHz         : 1468.375
>  > > cpu MHz         : 1309.000
>  > > cpu MHz         : 2212.125
>  > > $ grep MHz /proc/cpuinfo
>  > > cpu MHz         : 1255.875
>  > > cpu MHz         : 2690.250
>  > > cpu MHz         : 1255.875
>  > > cpu MHz         : 2530.875
>  > > cpu MHz         : 2212.125
>  > > cpu MHz         : 1521.500
>  > 
>  > This is odd.  On my Ivy Bridge system the CPU speed from /proc/cpuinfo 
>  > is at max freq once I set the performance governor.  
>  > The numbers above almost look like
>  > the cpu frequency is fluctuating and an average is taken.
>  > What version of the kernel are you running?  Is 
>  > CONFIG_CPU_FREQ_GOV_PERFORMANCE compiled in?
>  > 
>  > Does /sys/devices/system/cpu/cpu?/cpufreq/scaling_cur_freq
>  > also changes?
>  > 
>  > Can you check what are the available governors in your system
>  > and available frequencies?
>  > 
>  > cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_governors
>  > cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_frequencies
>  > 
>  > If userspace governor is available, you can try set the governor
>  > to userspace, then pin frequency to 3400 MHz (assuming that's your
>  > max) with command like:
>  
> intel_pstate overrides any governor choice you make through sysfs.
> 
> 	Dave
> 

Dirk,

Wonder if this the right behavior for intel_pstate that when I set the 
governor to performance, intel_pstate driver still adjusts 
the cpu frequencies around?

Turbotstat also confirms that the frequencies are not at max,
even though the max_perf_pct and min_perf_pct are both set at 100.  

I ran on my HSW system with 3.15-rc7 kernel and see similar
issue that Geroge reported.

It is really a pain when we need to do performance benchmarking and 
need to have a constant cpu frequency.  

Thanks.

Tim


  reply	other threads:[~2014-05-30 17:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-28 14:40 George Spelvin
2014-05-28 15:32 ` George Spelvin
2014-05-28 22:15   ` [PATCH v2] crypto: crc32c-pclmul - Shrink K_table to 32-bit words George Spelvin
2014-05-28 23:02     ` Tim Chen
2014-05-28 23:55       ` George Spelvin
2014-05-29  3:26       ` George Spelvin
2014-05-29 16:33         ` Tim Chen
2014-05-28 20:47 ` [RFC PATCH] crypto: crc32c-pclmul - Use pmovzxdq to shrink K_table Jan Beulich
2014-05-28 21:47   ` George Spelvin
2014-05-29  6:44     ` Jan Beulich
2014-05-28 22:32 ` Tim Chen
2014-05-28 23:01   ` George Spelvin
2014-05-28 23:28     ` Tim Chen
2014-05-29 23:54       ` George Spelvin
2014-05-30  1:07         ` Tim Chen
2014-05-30  1:16           ` Dave Jones
2014-05-30 17:56             ` Tim Chen [this message]
2014-05-30 18:45               ` Dirk Brandewie
2014-05-30 19:32                 ` Tim Chen
2014-05-30 19:38                   ` Dirk Brandewie
2014-05-30 20:07                     ` Tim Chen
2014-05-30 20:15                       ` Dirk Brandewie
2014-05-30  1:37           ` George Spelvin
2014-05-30  5:25             ` George Spelvin
2014-05-30 16:10               ` Tim Chen
2014-05-30 16:52                 ` George Spelvin
2014-05-30 17:01                   ` Tim Chen
2014-06-07  3:08                     ` [PATCH v3] crypto: crc32c-pclmul - Shrink K_table to 32-bit words George Spelvin
2014-06-20 18:42                       ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401472592.2970.483.camel@schen9-DESK \
    --to=tim.c.chen@linux.intel.com \
    --cc=JBeulich@suse.com \
    --cc=davej@redhat.com \
    --cc=dirk.brandewie@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jacob.jun.pan@intel.com \
    --cc=james.guilford@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®