From: Alex Elder <elder@linaro.org>
To: mturquette@linaro.org, mporter@linaro.org, bcm@fixthebug.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 1/7] clk: kona: allow nested ccu_write_enable() requests
Date: Fri, 30 May 2014 15:53:02 -0500 [thread overview]
Message-ID: <1401483188-5395-2-git-send-email-elder@linaro.org> (raw)
In-Reply-To: <1401483188-5395-1-git-send-email-elder@linaro.org>
Use a counter rather than a Boolean to track whether write access to
a CCU has been enabled or not. This will allow more than one of
these requests to be nested.
Note that __ccu_write_enable() and __ccu_write_disable() calls all
come in pairs, and they are always surrounded immediately by calls
to ccu_lock() and ccu_unlock().
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/clk/bcm/clk-kona.c | 14 ++++----------
drivers/clk/bcm/clk-kona.h | 2 +-
2 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c
index 95af2e6..ee8e988 100644
--- a/drivers/clk/bcm/clk-kona.c
+++ b/drivers/clk/bcm/clk-kona.c
@@ -170,13 +170,8 @@ static inline void ccu_unlock(struct ccu_data *ccu, unsigned long flags)
*/
static inline void __ccu_write_enable(struct ccu_data *ccu)
{
- if (ccu->write_enabled) {
- pr_err("%s: access already enabled for %s\n", __func__,
- ccu->name);
- return;
- }
- ccu->write_enabled = true;
- __ccu_write(ccu, 0, CCU_ACCESS_PASSWORD | 1);
+ if (!ccu->write_enabled++)
+ __ccu_write(ccu, 0, CCU_ACCESS_PASSWORD | 1);
}
static inline void __ccu_write_disable(struct ccu_data *ccu)
@@ -186,9 +181,8 @@ static inline void __ccu_write_disable(struct ccu_data *ccu)
ccu->name);
return;
}
-
- __ccu_write(ccu, 0, CCU_ACCESS_PASSWORD);
- ccu->write_enabled = false;
+ if (!--ccu->write_enabled)
+ __ccu_write(ccu, 0, CCU_ACCESS_PASSWORD);
}
/*
diff --git a/drivers/clk/bcm/clk-kona.h b/drivers/clk/bcm/clk-kona.h
index 2537b30..e9a8466 100644
--- a/drivers/clk/bcm/clk-kona.h
+++ b/drivers/clk/bcm/clk-kona.h
@@ -478,7 +478,7 @@ struct ccu_policy {
struct ccu_data {
void __iomem *base; /* base of mapped address space */
spinlock_t lock; /* serialization lock */
- bool write_enabled; /* write access is currently enabled */
+ u32 write_enabled; /* write access enable count */
struct ccu_policy policy;
struct list_head links; /* for ccu_list */
struct device_node *node;
--
1.9.1
next prev parent reply other threads:[~2014-05-30 20:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 20:53 [PATCH v4 0/7] clk: bcm: prerequisite and bus clock support Alex Elder
2014-05-30 20:53 ` Alex Elder [this message]
2014-05-30 23:28 ` [PATCH v4 1/7] clk: kona: allow nested ccu_write_enable() requests Mike Turquette
2014-05-31 3:46 ` Alex Elder
2014-06-02 21:05 ` Mike Turquette
2014-05-30 20:53 ` [PATCH v4 2/7] clk: kona: move some code Alex Elder
2014-05-30 20:53 ` [PATCH v4 3/7] clk: kona: don't init clocks at startup time Alex Elder
2014-05-30 23:37 ` Mike Turquette
2014-05-31 3:47 ` Alex Elder
2014-05-30 20:53 ` [PATCH v4 4/7] clk: bcm281xx: implement prerequisite clocks Alex Elder
2014-05-30 20:53 ` [PATCH v4 5/7] clk: bcm281xx: add bus clock support Alex Elder
2014-05-30 20:53 ` [PATCH v4 6/7] clk: bcm281xx: define a bus clock Alex Elder
2014-05-30 20:53 ` [PATCH v4 7/7] ARM: dts: add bus clock bsc3_apb for bcm281xx Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401483188-5395-2-git-send-email-elder@linaro.org \
--to=elder@linaro.org \
--cc=bcm@fixthebug.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@linaro.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome