From: Eric Dumazet <eric.dumazet@gmail.com>
To: Amir Vadai <amirv@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Or Gerlitz <ogerlitz@mellanox.com>,
netdev@vger.kernel.org, Yevgeny Petrilin <yevgenyp@mellanox.com>,
Yuval Atias <yuvala@mellanox.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint
Date: Sun, 01 Jun 2014 21:16:50 -0700 [thread overview]
Message-ID: <1401682610.3645.166.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1401029247-15196-3-git-send-email-amirv@mellanox.com>
On Sun, 2014-05-25 at 17:47 +0300, Amir Vadai wrote:
> From: Yuval Atias <yuvala@mellanox.com>
>
> The “affinity hint” mechanism is used by the user space
> daemon, irqbalancer, to indicate a preferred CPU mask for irqs.
> Irqbalancer can use this hint to balance the irqs between the
> cpus indicated by the mask.
>
> We wish the HCA to preferentially map the IRQs it uses to numa cores
> close to it. To accomplish this, we use cpumask_set_cpu_local_first(), that
> sets the affinity hint according the following policy:
> First it maps IRQs to “close” numa cores. If these are exhausted, the
> remaining IRQs are mapped to “far” numa cores.
>
> Signed-off-by: Yuval Atias <yuvala@mellanox.com>
> Signed-off-by: Amir Vadai <amirv@mellanox.com>
> ---
CC [M] drivers/net/ethernet/mellanox/mlx4/en_netdev.o
drivers/net/ethernet/mellanox/mlx4/en_netdev.c: In function ‘mlx4_en_init_affinity_hint’:
drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1546:23: error: incompatible types when assigning to type ‘cpumask_var_t’ from type ‘void *’
drivers/net/ethernet/mellanox/mlx4/en_netdev.c: In function ‘mlx4_en_free_affinity_hint’:
drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1553:41: error: incompatible types when assigning to type ‘cpumask_var_t’ from type ‘void *’
next prev parent reply other threads:[~2014-06-02 4:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 14:47 [PATCH net-next V6 0/2] cpumask,net: Affinity hint helper function Amir Vadai
2014-05-25 14:47 ` [PATCH net-next V6 1/2] cpumask: Utility function to set n'th cpu - local cpu first Amir Vadai
2014-05-27 19:24 ` David Miller
2014-05-28 5:49 ` Or Gerlitz
2014-05-25 14:47 ` [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint Amir Vadai
2014-06-02 4:16 ` Eric Dumazet [this message]
2014-06-02 4:37 ` Eric Dumazet
2014-06-02 4:56 ` David Miller
2014-06-02 5:13 ` Eric Dumazet
2014-06-02 7:10 ` David Miller
2014-06-02 14:08 ` Amir Vadai
2014-06-02 4:54 ` David Miller
2014-06-02 2:17 ` [PATCH net-next V6 0/2] cpumask,net: Affinity hint helper function David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401682610.3645.166.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
--cc=yuvala@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®