From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751582AbaFBEhR (ORCPT ); Mon, 2 Jun 2014 00:37:17 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:64091 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786AbaFBEhP (ORCPT ); Mon, 2 Jun 2014 00:37:15 -0400 Message-ID: <1401683831.3645.169.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint From: Eric Dumazet To: Amir Vadai Cc: "David S. Miller" , Or Gerlitz , netdev@vger.kernel.org, Yevgeny Petrilin , Yuval Atias , linux-kernel@vger.kernel.org Date: Sun, 01 Jun 2014 21:37:11 -0700 In-Reply-To: <1401682610.3645.166.camel@edumazet-glaptop2.roam.corp.google.com> References: <1401029247-15196-1-git-send-email-amirv@mellanox.com> <1401029247-15196-3-git-send-email-amirv@mellanox.com> <1401682610.3645.166.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2014-06-01 at 21:16 -0700, Eric Dumazet wrote: > On Sun, 2014-05-25 at 17:47 +0300, Amir Vadai wrote: > > From: Yuval Atias > > > > The “affinity hint” mechanism is used by the user space > > daemon, irqbalancer, to indicate a preferred CPU mask for irqs. > > Irqbalancer can use this hint to balance the irqs between the > > cpus indicated by the mask. > > > > We wish the HCA to preferentially map the IRQs it uses to numa cores > > close to it. To accomplish this, we use cpumask_set_cpu_local_first(), that > > sets the affinity hint according the following policy: > > First it maps IRQs to “close” numa cores. If these are exhausted, the > > remaining IRQs are mapped to “far” numa cores. > > > > Signed-off-by: Yuval Atias > > Signed-off-by: Amir Vadai > > --- > > CC [M] drivers/net/ethernet/mellanox/mlx4/en_netdev.o > drivers/net/ethernet/mellanox/mlx4/en_netdev.c: In function ‘mlx4_en_init_affinity_hint’: > drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1546:23: error: incompatible types when assigning to type ‘cpumask_var_t’ from type ‘void *’ > drivers/net/ethernet/mellanox/mlx4/en_netdev.c: In function ‘mlx4_en_free_affinity_hint’: > drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1553:41: error: incompatible types when assigning to type ‘cpumask_var_t’ from type ‘void *’ And : ERROR: "cpumask_set_cpu_local_first" [drivers/net/ethernet/mellanox/mlx4/mlx4_en.ko] undefined! $ git grep -n cpumask_set_cpu_local_first drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1542: if (cpumask_set_cpu_local_first(ring_idx, numa_node, include/linux/cpumask.h:260:int cpumask_set_cpu_local_first(int i, int numa_node, cpumask_t *dstp); lib/cpumask.c:168: * cpumask_set_cpu_local_first - set i'th cpu with local numa cpu's first lib/cpumask.c:182:int cpumask_set_cpu_local_first(int i, int numa_node, cpumask_t *dstp) lib/cpumask.c:228:EXPORT_SYMBOL(cpumask_set_cpu_local_first); Fixes are needed if CONFIG_CPUMASK_OFFSTACK is not used. $ grep CONFIG_CPUMASK_OFFSTACK .config $ echo $? 1