mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH 3/5] vt: Don't ignore unbind errors in vt_unbind
Date: Thu,  5 Jun 2014 16:58:26 +0200	[thread overview]
Message-ID: <1401980308-5116-3-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1401980308-5116-1-git-send-email-daniel.vetter@ffwll.ch>

Otherwise the loop will never stop since we don't make any
forward progress. Noticed while breaking this accidentally
in a painful attempt to make vga_con unregistering work.

With this patch we'll bail out on the first attempt, which
at least leaves a useful enough system behind for debugging.
Livelocks on console_lock just aren't fun.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/tty/vt/vt.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 5077fe87324d..3c00dcb3b145 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -3260,6 +3260,7 @@ static int vt_unbind(struct con_driver *con)
 {
 	const struct consw *csw = NULL;
 	int i, more = 1, first = -1, last = -1, deflt = 0;
+	int ret;
 
  	if (!con->con || !(con->flag & CON_DRIVER_FLAG_MODULE) ||
 	    con_is_graphics(con->con, con->first, con->last))
@@ -3285,8 +3286,10 @@ static int vt_unbind(struct con_driver *con)
 
 		if (first != -1) {
 			console_lock();
-			do_unbind_con_driver(csw, first, last, deflt);
+			ret = do_unbind_con_driver(csw, first, last, deflt);
 			console_unlock();
+			if (ret != 0)
+				return ret;
 		}
 
 		first = -1;
-- 
1.8.1.4


  parent reply	other threads:[~2014-06-05 14:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 14:58 [PATCH 1/5] vt: Fix replacement console check when unbinding Daniel Vetter
2014-06-05 14:58 ` [PATCH 2/5] vt: Fix up unregistration of vt drivers Daniel Vetter
2014-06-06  7:24   ` David Herrmann
2014-06-06  7:56     ` Daniel Vetter
2014-06-06  8:47       ` David Herrmann
2014-06-06  9:40         ` Daniel Vetter
2014-06-06 15:51           ` Greg Kroah-Hartman
2014-06-06 20:21             ` [Intel-gfx] " Daniel Vetter
2014-06-05 14:58 ` Daniel Vetter [this message]
2014-06-06  7:13   ` [PATCH 3/5] vt: Don't ignore unbind errors in vt_unbind David Herrmann
2014-06-05 14:58 ` [PATCH 4/5] drm/i915: Fixup global gtt cleanup Daniel Vetter
2014-06-06 13:22   ` Imre Deak
2014-06-05 14:58 ` [PATCH 5/5] drm/i915: Kick out vga console Daniel Vetter
2014-06-06  7:28   ` David Herrmann
2014-06-06  7:47     ` Daniel Vetter
2014-06-06 15:20   ` Daniel Vetter
2014-06-09 13:22     ` Tomi Valkeinen
     [not found]   ` <1602327.OGkKxHtt2b@grover>
2014-06-29  3:55     ` Ed Tomlinson
2014-06-30  6:59       ` Chris Wilson
2014-06-30  8:19         ` David Herrmann
2014-07-01 13:51         ` Ed Tomlinson
2014-07-07  8:48         ` [Intel-gfx] " Daniel Vetter
2014-07-07 10:45           ` Ed Tomlinson
2014-07-07 12:26             ` Daniel Vetter
2014-07-08  2:53               ` Ed Tomlinson
2014-07-08  8:10                 ` Daniel Vetter
2014-07-07 10:59           ` Ed Tomlinson
2014-06-06  7:16 ` [PATCH 1/5] vt: Fix replacement console check when unbinding David Herrmann
2014-06-06  7:49   ` Daniel Vetter
2014-06-06  9:43 ` [PATCH] " Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401980308-5116-3-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®