From: Bart Van Assche <bvanassche@acm.org>
To: TJ Adams <tadamsjr@google.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <mkp@kernel.org>
Cc: John Garry <john.garry@linux.dev>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: pm8001: Offset hardware queue index for MSI-X pre-vector
Date: Mon, 16 Nov 2026 15:04:37 -0800 [thread overview]
Message-ID: <1401d9ab-4075-46fd-8a99-ed818762bb1a@acm.org> (raw)
In-Reply-To: <20261116224811.3362188-1-tadamsjr@google.com>
On 11/16/26 2:48 PM, TJ Adams wrote:
> - return blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(rq));
> + if (pm8001_ha->number_of_intr > 1)
> + return blk_mq_unique_tag_to_hwq(blk_mq_unique_tag(rq)) + 1;
If "1" in the above statement is not changed into a symbolic constant,
it will be very hard for anyone who reads the code of this driver to
determine where that constant comes from.
Thanks,
Bart.
prev parent reply other threads:[~2026-11-16 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 22:48 TJ Adams
2026-11-16 23:04 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401d9ab-4075-46fd-8a99-ed818762bb1a@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.garry@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=tadamsjr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®