From: Ken Helias <kenhelias@web.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Ken Helias <kenhelias@firemail.de>
Subject: [PATCHv2 01/13] list: Use argument hlist_add_after names from rcu variant
Date: Fri, 6 Jun 2014 19:34:20 +0200 [thread overview]
Message-ID: <1402076072-4044-1-git-send-email-kenhelias@web.de> (raw)
From: Ken Helias <kenhelias@firemail.de>
The argument names of the hlist_add_after are poorly chosen because they look
the same as the ones from hlist_add_before but have to be used completely
different. This easily confuses the reader. The creator of the
hlist_add_after_rcu function has made a lot better choice.
Signed-off-by: Ken Helias <kenhelias@firemail.de>
---
v2:
Splitted into two patches
include/linux/list.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/linux/list.h b/include/linux/list.h
index ef95941..624ec7f 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -654,15 +654,15 @@ static inline void hlist_add_before(struct hlist_node *n,
*(n->pprev) = n;
}
-static inline void hlist_add_after(struct hlist_node *n,
- struct hlist_node *next)
+static inline void hlist_add_after(struct hlist_node *prev,
+ struct hlist_node *n)
{
- next->next = n->next;
- n->next = next;
- next->pprev = &n->next;
+ n->next = prev->next;
+ prev->next = n;
+ n->pprev = &prev->next;
- if(next->next)
- next->next->pprev = &next->next;
+ if (n->next)
+ n->next->pprev = &n->next;
}
/* after that we'll appear to be on some hlist and hlist_del will work */
--
2.0.0
next reply other threads:[~2014-06-06 17:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 17:34 Ken Helias [this message]
2014-06-06 17:34 ` [PATCHv2 02/13] list: Fix order of arguments for hlist_add_after(_rcu) Ken Helias
2014-06-06 17:34 ` [PATCH 03/13] list: Add list_add_(before|after) macros Ken Helias
2014-06-06 19:51 ` Hugh Dickins
2014-06-07 13:34 ` Christoph Hellwig
2014-06-06 17:34 ` [PATCH 04/13] metag: dma: Use " Ken Helias
2014-06-06 17:34 ` [PATCH 05/13] powerpc: " Ken Helias
2014-06-06 17:34 ` [PATCH 06/13] EDAC: " Ken Helias
2014-06-06 17:34 ` [PATCH 07/13] PCI: " Ken Helias
2014-06-06 17:34 ` [PATCH 08/13] mac80211: " Ken Helias
2014-06-06 17:34 ` [PATCH 09/13] jfs: " Ken Helias
2014-06-06 17:34 ` [PATCH 10/13] xhci: " Ken Helias
2014-06-06 17:34 ` [PATCH 11/13] iscsi-target: " Ken Helias
2014-06-06 17:34 ` [PATCH 12/13] s390: " Ken Helias
2014-06-06 17:34 ` [PATCH 13/13] staging: tidspbridge: " Ken Helias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402076072-4044-1-git-send-email-kenhelias@web.de \
--to=kenhelias@web.de \
--cc=akpm@linux-foundation.org \
--cc=kenhelias@firemail.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®