mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wang, Xiaoming" <xiaoming.wang@intel.com>
To: tiwai@suse.de, vinod.koul@intel.com, jeeja.kp@intel.com,
	dhowells@redhat.com, arnd@arndb.de, tglx@linutronix.de,
	mtk.manpages@gmail.com, paulmck@linux.vnet.ibm.com,
	davej@redhat.com, linux-kernel@vger.kernel.org
Cc: dongxing.zhang@intel.com, xiaoming.wang@intel.com
Subject: [PATCH] ALSA: compress: Fix the mismatch size of struc between share lib(32bit) and kernel(64bit)
Date: Mon, 09 Jun 2014 16:46:32 -0400	[thread overview]
Message-ID: <1402346792.30956.17.camel@wxm-ubuntu> (raw)


The size of struct snd_compr_avail is 0x1c in 32bit kernel,
while it is 0x20 in 64bit kernel 0x4 bytes added because of
alignment. It is OK when 32bit kernel met 32bit user space.
There exist stack corruption if 64bit kernel met 32bit user
space, because the size of struct snd_compr_avail is 0x1c
in 32bit user space which is smaller than it will get from
kernel. The extra 4 bytes can corrupt the stack, and
introduce unpredictable error.

Signed-off-by: Zhang Dongxing <dongxing.zhang@intel.com>
Signed-off-by: xiaoming wang <xiaoming.wang@intel.com>
---
 include/uapi/sound/compress_offload.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h
index 5759810..766b416 100644
--- a/include/uapi/sound/compress_offload.h
+++ b/include/uapi/sound/compress_offload.h
@@ -70,6 +70,7 @@ struct snd_compr_tstamp {
 	__u32 pcm_frames;
 	__u32 pcm_io_frames;
 	__u32 sampling_rate;
+	__u32 reserved[1];
 };
 
 /**
-- 
1.7.1


             reply	other threads:[~2014-06-09  6:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09 20:46 Wang, Xiaoming [this message]
2014-06-09  7:24 ` Takashi Iwai
2014-06-09 15:35   ` Vinod Koul
2014-06-12  6:39     ` Wang, Xiaoming
2014-06-13 14:19     ` Arnd Bergmann
2014-06-17  3:06       ` Vinod Koul
2014-06-17 11:48         ` Arnd Bergmann
2014-06-19  5:13           ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402346792.30956.17.camel@wxm-ubuntu \
    --to=xiaoming.wang@intel.com \
    --cc=arnd@arndb.de \
    --cc=davej@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=dongxing.zhang@intel.com \
    --cc=jeeja.kp@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®