mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Cc: "Ming Lei" <tom.leiming@gmail.com>,
	"Matias Bjørling" <m@bjorling.me>,
	"Christoph Hellwig" <hch@lst.de>
Subject: [PATCH] blk-mq: kick requeue list in blk_mq_requeue_request()
Date: Tue, 10 Jun 2014 12:52:05 +0800	[thread overview]
Message-ID: <1402375925-21720-1-git-send-email-tom.leiming@gmail.com> (raw)

blk_mq_requeue_request() should kick off the requeue list so
that the request can be scheduled to queue finally.

In nvme conversion patch, blk_mq_requeue_request() is called
to requeue failed request from completion handler, this patch
fixes the issue and makes the block API working as expected.

Cc: Matias Bjørling <m@bjorling.me>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 block/blk-mq.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index cb4c785..4c78539 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -462,6 +462,7 @@ void blk_mq_requeue_request(struct request *rq)
 
 	BUG_ON(blk_queued_rq(rq));
 	blk_mq_add_to_requeue_list(rq, true);
+	blk_mq_kick_requeue_list(rq->q);
 }
 EXPORT_SYMBOL(blk_mq_requeue_request);
 
-- 
1.7.9.5


             reply	other threads:[~2014-06-10  4:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10  4:52 Ming Lei [this message]
2014-06-10 11:28 ` Christoph Hellwig
2014-06-10 11:45   ` Ming Lei
2014-06-10 12:45     ` Christoph Hellwig
2014-06-10 14:47       ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402375925-21720-1-git-send-email-tom.leiming@gmail.com \
    --to=tom.leiming@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@bjorling.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome