From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6290737AA99 for ; Tue, 7 Jul 2026 19:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783451642; cv=none; b=IKgdwNyDWw9KVvPMGYY8Ii8CJKrqI1djvKZyALMMNKhpFIMuS1TXTeoc5ZNguMglBMGBq/cRyS69p2sfEyHtFjtOl4emc3PGcMZm9hEH2yK8echGmUFcYPX41BQ0dq0pwLdQyBEs0N9VXrfqAqWqdGEVptKM4DeWG/q5KNhS4W4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783451642; c=relaxed/simple; bh=Q0yebGwL8eWx1vNOrVrrq1jpOqA3B/QDaiR5qfl5as8=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=rYDpT071Kkyi9IMjron9/c1qBtbjd1+0Fg1j4071TymFOuDqyyntZ1ruox/r7+t6KL/bWEuJ97roIEKC6aCgcgBpKHyVnftOtKSDJqADHKdHQ0JN14I/IhC/iNsCwAmP8WuxPbq+tiJb0ObiBLoU2idKdWVtYQk7oX0cy8V5I04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=GRmR70lc; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="GRmR70lc" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-92c7a0a701aso1109785a.3 for ; Tue, 07 Jul 2026 12:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1783451640; x=1784056440; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=SGfDZeEdLGeen0qW0nrFDO6a/FMS/fYRJh5VUHrysIk=; b=GRmR70lczsMV8NilnhewKXlOJqrtkmcEsfcu7rEYi/zAiio08xkrPeUoHb+AtS3hBj nRqAIsGV6+YyHkJdFC3WSFGvSUSaVLzkxykuPo48EOiGPQchnS4bHoZAWl5vtFQOyt7b 65IHe3/lIwhc2Q4acrnQNwGT9uoaN03byQY+zthYe92pvfuzZXTzOPDhKrofQy2kMd6L RmQ1p3NCvrEJgPQmvqmSKCr4148hqTcMIHI7vn0fW2QdHoKkzN1UCFj2r6hGSECBzTvj qI9n/CGjHFKLFjc/j6Y3KvEjoZF33Cvkf1RA0x7iDW5ezyuaIZ5rpXbJ4cgP8WVpO3Az bwhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783451640; x=1784056440; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SGfDZeEdLGeen0qW0nrFDO6a/FMS/fYRJh5VUHrysIk=; b=XEfrGur8cPc09ijTh/lohk0h29gpQ4MmG0f7RRMSPWXiQttJbY40f0oRBU17o566At l0hnPJAzpWyy1PD3RUNbsOrboru6LiepiyMfGMHUrz5Ep7G0ydNufoS2EQVwK6q4G94i sDP6YDLSXKfg0crlvhMo5Ep55WrtDom9KbF+e4UJqDP0XmHs11Mj4z4zMm6X9yMBejx7 J++LPweVqJJ7YsGXtLrr1xXvoPBOLYJFymraHoDLMrr7UWCbzrG0j74Cilw1+wKatbjw YIhs20S8m73p4uD0UNDiVpfA9uMyN0QdHCJtJRUKREJ1mrhH+YUzEzyq/pPZPvTfYVH9 ix6A== X-Forwarded-Encrypted: i=1; AHgh+Rp27QkBsTJVHvrUfMI3cK/r4kKjb6LrXhBJCZLRVGwbozsx/2kq57aY2E7N8Wnz7LicdgSzZGCpVvtNz7k=@vger.kernel.org X-Gm-Message-State: AOJu0YzmOCRaT+vOJz6gMC/px/H5hw1iq7p3f1QMoWquOEPA94L3UmZ/ 3Z799EYqcvEejcDlGj0LhOvPLcQapqnlZ4K/G9CHNOPk9Mt4bT5Mj6JkZwE9kdLa8w== X-Gm-Gg: AfdE7clXPx2kHAY5b8pc/tGVk/Fb7mPlPvJ5VpZkbkYZdqP1ZbyRg8eVA8cDJ6RmEyM QXkiz4WzYdXCbt4+VcFGMfIaDOAk9h2bId9sn7+ozAdCzuJ+VVRgP4OIZGJRqm2xOgT78nZpsPI JmFFOx56IZH3z0fhSZgrp7CGah3z4Fa3fhKoqraefqPetJD1tKVhptUP4K3Q/X7sxY85ZG2yJeD bepT87YBdXB936t46JZZ7LIApSbVzAiUPXicezvWPy88h5afPWWeqDvLtxjKTfxFQqwCfdymxbd +9xpMgwSRNBqVF/YhYVqbw8GyfpplEblc7SdqkIcMxvzW0qGsywWDovispXMJA1hyQr65KmH+8L OFpxZjfZj3KOZU7WxXcTO8MNa4mJzGUaSAhnqUPGbSDh1rHV6BXCnzzF+CjBOLypovmq2IvPB8m kdizpcBIlVQN8PUPPPgcFLyBct+/8QNKtQKMaTavthyzge6kmN9UzBJbRPpw== X-Received: by 2002:a05:620a:4515:b0:915:7fe4:cac5 with SMTP id af79cd13be357-92ebb57dfcbmr743131685a.49.1783451640236; Tue, 07 Jul 2026 12:14:00 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92e90ba4209sm1318251385a.12.2026.07.07.12.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 12:13:58 -0700 (PDT) Date: Tue, 07 Jul 2026 15:13:58 -0400 Message-ID: <14023e3368d98072f369e6fe1607c7d5@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260707_1504/pstg-lib:20260707_1258/pstg-pwork:20260707_1504 From: Paul Moore To: Wang Yan , bill.c.roberts@gmail.com Cc: casey@schaufler-ca.com, jmorris@namei.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, mic@digikod.net, serge@hallyn.com, shuah@kernel.org, wangyan01@kylinos.cn Subject: Re: [PATCH v2] selftests/lsm: Fix memory leak in attr_lsm_count References: <20260703120951.1622491-1-wangyan01@kylinos.cn> In-Reply-To: <20260703120951.1622491-1-wangyan01@kylinos.cn> On Jul 3, 2026 Wang Yan wrote: > > The calloc-allocated buffer in attr_lsm_count() is never released on > any exit path, including both the normal return path and the early > return when read_sysfs_lsms fails, resulting in a heap memory leak. > > Add free() for the buffer on all return branches to fix the leak. > > Fixes: d3d929a8b0cd ("LSM: selftests for Linux Security Module syscalls") > Signed-off-by: Wang Yan > Reviewed-by: William Roberts > Tested-by: William Roberts > --- > tools/testing/selftests/lsm/common.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Merged into lsm/dev, thanks! -- paul-moore.com