From: Grygorii Strashko <grygorii.strashko@ti.com>
To: <geert+renesas@glider.be>
Cc: <laurent.pinchart@ideasonboard.com>, <ulf.hansson@linaro.org>,
<khilman@linaro.org>, <grant.likely@secretlab.ca>,
<mturquette@linaro.org>, <tomasz.figa@gmail.com>,
<ben.dooks@codethink.co.uk>, <horms@verge.net.au>,
<magnus.damm@gmail.com>, <rjw@rjwysocki.net>,
<linux-sh@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: [RFC PATCH 0/2] use named clocks list to register clocks for PM clock domain
Date: Thu, 12 Jun 2014 19:53:41 +0300 [thread overview]
Message-ID: <1402592023-13416-1-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1398334403-26181-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
I've spent some time testing your patches on Keystone 2 SoC as I am interested
in these patches.
The Keystone 2 is pure DT platform, but we reuse some Drivers from Davinci SoC.
Now I have to dial with following problem:
- Some modules on Keystone need more then one clock to be managed by PM clock.
As result, I can solve this by filling cond_id list in structure
pm_clk_notifier_block.
For example:
static struct pm_clk_notifier_block platform_domain_notifier = {
.pm_domain = &keystone_pm_domain,
.con_ids = { "fck", "master", "slave", NULL },
};
But, in this case I'll need to add names for all clocks or rename existed
clock's names in DT to be compatible with above list, like:
clock-names = "gpio"; -> clock-names = "fck";
- or -
clocks = <&clkspi>;
+ clock-names = "fck";
Your series gracefully solves this problem for me, but I'd like to avoid
to use new CLK flag CLK_RUNTIME_PM, because:
- The same driver is used for all gated clocks for Keystone (and probably for
other SoCs)
- Some gated clocks can be optional.
Taking into account above, driver for gated clock will need to maintain additional
information internally about clocks which are suitable for Runtime PM -
it is too hard to support :(.
Therefore, I propose a solution which allows to specify clocks suitable for
Runtime PM in DT using special property "clkops-clocks" (name can be changed:).
Another possible option is to use DT definition like this:
spi2: spi@21000800 {
compatible = "ti,dm6441-spi";
reg = <0x21000800 0x200>;
num-cs = <4>;
ti,davinci-spi-intr-line = <0>;
interrupts = <GIC_SPI 300 IRQ_TYPE_EDGE_RISING>;
-> clkops-clocks {
-> clocks = <&clkspi>;
-> }
}
Regarding supporting of EPROBE_DEFER, in my opinion simplest solution would be to
call of_clk_register_runtime_pm_clocks() directly from drivers.
Another option 1, call of_clk_register_runtime_pm_clocks() before driver's probing
seems will be banned by Greg and Rafael.
Another option 2, continue to use Bus notifiers, but then error path need to be
handled somehow. Now BUS_NOTIFY_BIND_DRIVER even is sent before probing, but
it seems that nothing is sent in case if probe was failed.
Grygorii Strashko (2):
clk: of: introduce of_clk_get_from_set()
of/clk: use "clkops-clocks" to specify clocks handled by clock_ops
domain
drivers/clk/clkdev.c | 24 ++++++++++++++++++++++--
drivers/of/of_clk.c | 7 ++-----
include/linux/clk.h | 7 +++++++
3 files changed, 31 insertions(+), 7 deletions(-)
--
1.7.9.5
next prev parent reply other threads:[~2014-06-12 16:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 10:13 [PATCH/RFC 0/4] of: Register clocks for Runtime PM with PM core Geert Uytterhoeven
2014-04-24 10:13 ` [PATCH/RFC 1/4] clk: Add CLK_RUNTIME_PM and clk_may_runtime_pm() Geert Uytterhoeven
2014-04-24 10:13 ` [PATCH/RFC 2/4] PM / clock_ops: Add pm_clk_add_clk() Geert Uytterhoeven
2014-04-24 10:13 ` [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core Geert Uytterhoeven
2014-04-24 13:11 ` Ulf Hansson
2014-04-24 14:09 ` Geert Uytterhoeven
2014-04-26 1:59 ` Tomasz Figa
2014-05-02 8:13 ` Ulf Hansson
2014-05-02 14:58 ` Geert Uytterhoeven
2014-05-06 7:58 ` Ulf Hansson
2014-04-30 21:23 ` Laurent Pinchart
2014-04-30 22:06 ` Geert Uytterhoeven
2014-04-25 23:44 ` Kevin Hilman
2014-04-29 13:16 ` Grant Likely
2014-04-30 21:25 ` Laurent Pinchart
2014-04-30 21:33 ` Ben Dooks
2014-04-30 21:54 ` Geert Uytterhoeven
2014-05-01 8:03 ` Grant Likely
2014-05-01 13:41 ` Geert Uytterhoeven
2014-05-01 13:56 ` Grant Likely
2014-05-01 14:46 ` Geert Uytterhoeven
2014-04-30 21:47 ` Geert Uytterhoeven
2014-05-02 8:56 ` Ulf Hansson
2014-05-02 14:35 ` Geert Uytterhoeven
2014-05-06 7:43 ` Ulf Hansson
2014-04-24 10:13 ` [PATCH/RFC 4/4] clk: shmobile: mstp: Set CLK_RUNTIME_PM flag Geert Uytterhoeven
2014-04-30 21:29 ` [PATCH/RFC 0/4] of: Register clocks for Runtime PM with PM core Laurent Pinchart
2014-04-30 22:17 ` Geert Uytterhoeven
2014-06-12 16:53 ` Grygorii Strashko [this message]
2014-06-12 16:53 ` [RFC PATCH 1/2] clk: of: introduce of_clk_get_from_set() Grygorii Strashko
2014-06-12 16:53 ` [RFC PATCH 2/2] of/clk: use "clkops-clocks" to specify clocks handled by clock_ops domain Grygorii Strashko
2014-07-28 14:05 ` Grant Likely
2014-07-28 17:47 ` Grygorii Strashko
2014-07-29 5:52 ` Grant Likely
2014-07-30 0:06 ` Laurent Pinchart
2014-07-30 13:25 ` Grygorii Strashko
2014-12-12 17:40 ` Laurent Pinchart
2014-08-04 11:28 ` Geert Uytterhoeven
2014-08-04 15:21 ` Laurent Pinchart
2014-09-08 20:13 ` Kevin Hilman
2014-12-12 17:52 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402592023-13416-1-git-send-email-grygorii.strashko@ti.com \
--to=grygorii.strashko@ti.com \
--cc=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=grant.likely@secretlab.ca \
--cc=horms@verge.net.au \
--cc=khilman@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=tomasz.figa@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®