From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753665AbaFMQhu (ORCPT ); Fri, 13 Jun 2014 12:37:50 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:45334 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753225AbaFMQht (ORCPT ); Fri, 13 Jun 2014 12:37:49 -0400 From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, jason@lakedaemon.net, computersforpeace@gmail.com, Florian Fainelli Subject: [PATCH] genirq: warn on inconstent flags and flow handler Date: Fri, 13 Jun 2014 09:36:43 -0700 Message-Id: <1402677403-3542-1-git-send-email-f.fainelli@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is currently possible for a generic irq chip driver to set IRQ_LEVEL and have its irq flow handler be handle_edge_irq. Setting IRQ_LEVEL in such a case does not make sense, and will actually prevent e.g: the software resend logic from kicking, and potential other problems too. Signed-off-by: Florian Fainelli --- Thomas, This is the change I mentioned to you on the #mipslinux IRC channel, let me know if you feel like this should be somewhere else, AFAICT this should not slow things down. Thanks! kernel/irq/chip.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index a2b28a2fd7b1..939ae1283ec9 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -749,8 +749,13 @@ void irq_modify_status(unsigned int irq, unsigned long clr, unsigned long set) irqd_set(&desc->irq_data, IRQD_PER_CPU); if (irq_settings_can_move_pcntxt(desc)) irqd_set(&desc->irq_data, IRQD_MOVE_PCNTXT); - if (irq_settings_is_level(desc)) + if (irq_settings_is_level(desc)) { + /* Setting IRQD_LEVEL does not make sense on non-level + * sensitive interrupts + */ + WARN_ON(desc->handle_irq != handle_level_irq); irqd_set(&desc->irq_data, IRQD_LEVEL); + } irqd_set(&desc->irq_data, irq_settings_get_trigger_mask(desc)); -- 1.9.1