From: Liu Ying <Ying.Liu@freescale.com>
To: <linux-kernel@vger.kernel.org>
Cc: <rmk+kernel@arm.linux.org.uk>, <gregkh@linuxfoundation.org>
Subject: [PATCH] drivers/base: redundant return value settings in try_to_bring_up_master()
Date: Tue, 17 Jun 2014 16:25:31 +0800 [thread overview]
Message-ID: <1402993531-25244-1-git-send-email-Ying.Liu@freescale.com> (raw)
Remove redundant return value settings 'ret = 0;' in the function
try_to_bring_up_master(), since it has already been set to zero.
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
drivers/base/component.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/base/component.c b/drivers/base/component.c
index c477899..007600e 100644
--- a/drivers/base/component.c
+++ b/drivers/base/component.c
@@ -123,13 +123,11 @@ static int try_to_bring_up_master(struct master *master,
if (master->ops->add_components(master->dev, master)) {
/* Failed to find all components */
master_remove_components(master);
- ret = 0;
goto out;
}
if (component && component->master != master) {
master_remove_components(master);
- ret = 0;
goto out;
}
--
1.7.9.5
next reply other threads:[~2014-06-17 8:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 8:25 Liu Ying [this message]
2014-07-12 0:58 ` Greg KH
2014-07-14 2:17 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402993531-25244-1-git-send-email-Ying.Liu@freescale.com \
--to=ying.liu@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®