mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philippe De Muyter <phdm@macqel.be>
To: linux-kernel@vger.kernel.org
Cc: Philippe De Muyter <phdm@macqel.be>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] init/do_mounts.c: treat EROFS like EACCES
Date: Wed, 18 Jun 2014 18:12:44 +0200	[thread overview]
Message-ID: <1403107964-1082-1-git-send-email-phdm@macqel.be> (raw)

some combinations of filesystem and block device (at least vfat on mmc)
yield -EROFS instead of -EACCES when the device is read-only.  Retry
mounting with MS_RDONLY set, just like for the EACCES case, instead of
failing directly.

Signed-off-by: Philippe De Muyter <phdm@macqel.be>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
 init/do_mounts.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/init/do_mounts.c b/init/do_mounts.c
index 82f2288..af7b9b8 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -394,6 +394,7 @@ retry:
 			case 0:
 				goto out;
 			case -EACCES:
+			case -EROFS:
 				flags |= MS_RDONLY;
 				goto retry;
 			case -EINVAL:
-- 
1.7.5.3


             reply	other threads:[~2014-06-18 16:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18 16:12 Philippe De Muyter [this message]
2014-06-19 21:19 ` Andrew Morton
2014-06-19 23:09   ` Dave Chinner
2014-06-20  8:39     ` [PATCH] VFS: mount must return EACCES, not EROFS Philippe De Muyter
2014-06-27  8:20       ` [PATCH PING] " Philippe De Muyter
2014-07-02 19:46         ` Andrew Morton
2014-07-03 16:29           ` Philippe De Muyter
2014-07-08 21:02             ` Andrew Morton
2014-07-15 10:05               ` Philippe De Muyter
2014-06-20 13:13     ` [PATCH] init/do_mounts.c: treat EROFS like EACCES Philippe De Muyter
2014-06-23  9:22       ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403107964-1082-1-git-send-email-phdm@macqel.be \
    --to=phdm@macqel.be \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®