From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129AbaFSBHU (ORCPT ); Wed, 18 Jun 2014 21:07:20 -0400 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:52198 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751971AbaFSBHS (ORCPT ); Wed, 18 Jun 2014 21:07:18 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:4321:4605:5007:7652:7903:9040:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13161:13229:13311:13357,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: stamp20_53d39259e349 X-Filterd-Recvd-Size: 1908 Message-ID: <1403140033.14018.12.camel@joe-AO725> Subject: Re: [PATCH 2/3] w1: use pr_* instead of printk From: Joe Perches To: Fjodor Schelichow Cc: Evgeniy Polyakov , Greg Kroah-Hartman , David Fries , Michael Opdenacker , Jingoo Han , linux-kernel@vger.kernel.org, Roman Sommer , linux-kernel@i4.cs.fau.de Date: Wed, 18 Jun 2014 18:07:13 -0700 In-Reply-To: <1403139121-2431-3-git-send-email-fjodor.schelichow@hotmail.com> References: <1403139121-2431-1-git-send-email-fjodor.schelichow@hotmail.com> <1403139121-2431-3-git-send-email-fjodor.schelichow@hotmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-06-19 at 02:52 +0200, Fjodor Schelichow wrote: > This patch replaces all calls to the "printk" function within the main "w1" > directory by calls to the appropriate "pr_*" function thus addressing > the following warning generated by the checkpatch script: [] > diff --git a/drivers/w1/w1_log.h b/drivers/w1/w1_log.h [] > @@ -29,8 +29,8 @@ > #else > # define assert(expr) \ > if(unlikely(!(expr))) { \ > - printk(KERN_ERR "Assertion failed! %s,%s,%s,line=%d\n", \ > - #expr, __FILE__, __func__, __LINE__); \ > + pr_err("Assertion failed! %s,%s,%s,line=%d\n", \ > + #expr, __FILE__, __func__, __LINE__); \ > } These macros should really be surrounded by a do { ... } while (0)