From: Joe Perches <joe@perches.com>
To: josh@joshtriplett.org
Cc: Johannes Stadlinger <Johannes.Stadlinger@fau.de>,
devel@linuxdriverproject.org,
Maximilian Eschenbacher <maximilian@eschenbacher.email>,
linux-kernel@i4.cs.fau.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vitaly Osipov <vitaly.osipov@gmail.com>,
Himangi Saraogi <himangi774@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] wlan-ng/prism2mib:checkpatch: Insert blank lines
Date: Thu, 19 Jun 2014 13:25:18 -0700 [thread overview]
Message-ID: <1403209518.2753.4.camel@joe-AO725> (raw)
In-Reply-To: <20140619201459.GD16404@cloud>
On Thu, 2014-06-19 at 13:14 -0700, josh@joshtriplett.org wrote:
> On Thu, Jun 19, 2014 at 09:20:17PM +0200, Johannes Stadlinger wrote:
> > This patch inserts blank lines after declarations to avoid checkpatch
> > warning.
[]
> > diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
[]
> > @@ -85,7 +85,8 @@ struct mibrec {
> > u16 parm1;
> > u16 parm2;
> > u16 parm3;
> > - int (*func) (struct mibrec *mib,
> > +
> > + int (*func)(struct mibrec *mib,
>
> Eliminating the space here makes sense, but checkpatch shouldn't warn
> about spaces after declarations between two fields in the middle of a
> structure declaration.
It's a defect in checkpatch,
It's fixed in the latest version in -next
https://lkml.org/lkml/2014/6/6/426
next prev parent reply other threads:[~2014-06-19 20:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 19:20 [PATCH 1/8] wlan-ng/prism2mgmt:checkpatch: Fix long lines Johannes Stadlinger
2014-06-19 19:20 ` [PATCH 2/8] wlan-ng/prism2mgmt:checkpatch: Fix string split Johannes Stadlinger
2014-06-19 20:09 ` josh
2014-06-19 19:20 ` [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line Johannes Stadlinger
2014-06-19 20:11 ` josh
2014-06-20 8:14 ` Dan Carpenter
2014-06-19 19:20 ` [PATCH 4/8] wlan-ng/prism2mib:checkpatch: Fix string split Johannes Stadlinger
2014-06-19 20:12 ` josh
2014-06-19 19:20 ` [PATCH 5/8] wlan-ng/prism2mib:checkpatch: Insert blank lines Johannes Stadlinger
2014-06-19 20:14 ` josh
2014-06-19 20:25 ` Joe Perches [this message]
2014-06-19 19:20 ` [PATCH 6/8] wlan-ng/prism2sta:checkpatch: Fix long lines Johannes Stadlinger
2014-06-19 20:19 ` josh
2014-06-19 20:22 ` Joe Perches
2014-06-19 19:20 ` [PATCH 7/8] wlan-ng/prism2sta:checkpatch: Fix string split Johannes Stadlinger
2014-06-19 20:20 ` josh
2014-06-19 19:20 ` [PATCH 8/8] wlan-ng/prism2sta:checkpatch: Insert blank lines Johannes Stadlinger
2014-06-19 20:20 ` josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403209518.2753.4.camel@joe-AO725 \
--to=joe@perches.com \
--cc=Johannes.Stadlinger@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maximilian@eschenbacher.email \
--cc=vitaly.osipov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®