From: Pramod Gurav <pramod.gurav.etc@gmail.com>
To: linux-kernel@vger.kernel.org, inux-pm@vger.kernel.org
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Pramod Gurav <pramod.gurav.etc@gmail.com>
Subject: [PATCH] cpuidle: Fix Coding style reported by checkpatch.pl
Date: Fri, 20 Jun 2014 16:27:45 +0530 [thread overview]
Message-ID: <1403261865-7472-1-git-send-email-pramod.gurav.etc@gmail.com> (raw)
Fixed: ERROR: do not use assignment in if condition
Fixed: WARNING: EXPORT_SYMBOL should immediately follow its function
Fixed: WARNING: line over 80 characters in a comment
CC: Rafael J. Wysocki <rjw@rjwysocki.net>
CC: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
---
drivers/cpuidle/cpuidle.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 8236746..2c8752e 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -179,7 +179,9 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index)
void cpuidle_install_idle_handler(void)
{
if (enabled_devices) {
- /* Make sure all changes finished before we switch to new idle */
+ /*
+ * Make sure all changes finished before we switch to new idle
+ */
smp_wmb();
initialized = 1;
}
@@ -204,7 +206,6 @@ void cpuidle_pause_and_lock(void)
mutex_lock(&cpuidle_lock);
cpuidle_uninstall_idle_handler();
}
-
EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
/**
@@ -215,7 +216,6 @@ void cpuidle_resume_and_unlock(void)
cpuidle_install_idle_handler();
mutex_unlock(&cpuidle_lock);
}
-
EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
/* Currently used in suspend/resume path to suspend cpuidle */
@@ -267,9 +267,11 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
if (ret)
return ret;
- if (cpuidle_curr_governor->enable &&
- (ret = cpuidle_curr_governor->enable(drv, dev)))
- goto fail_sysfs;
+ if (cpuidle_curr_governor->enable) {
+ ret = cpuidle_curr_governor->enable(drv, dev);
+ if (ret)
+ goto fail_sysfs;
+ }
smp_wmb();
@@ -283,7 +285,6 @@ fail_sysfs:
return ret;
}
-
EXPORT_SYMBOL_GPL(cpuidle_enable_device);
/**
@@ -311,7 +312,6 @@ void cpuidle_disable_device(struct cpuidle_device *dev)
cpuidle_remove_device_sysfs(dev);
enabled_devices--;
}
-
EXPORT_SYMBOL_GPL(cpuidle_disable_device);
static void __cpuidle_unregister_device(struct cpuidle_device *dev)
@@ -399,7 +399,6 @@ out_unregister:
__cpuidle_unregister_device(dev);
goto out_unlock;
}
-
EXPORT_SYMBOL_GPL(cpuidle_register_device);
/**
@@ -423,7 +422,6 @@ void cpuidle_unregister_device(struct cpuidle_device *dev)
cpuidle_resume_and_unlock();
}
-
EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
/**
--
1.7.9.5
next reply other threads:[~2014-06-20 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 10:57 Pramod Gurav [this message]
2014-06-20 10:58 ` pramod gurav
2014-07-14 7:10 ` pramod gurav
2014-07-14 18:08 ` Rafael J. Wysocki
2014-07-15 5:12 ` pramod gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403261865-7472-1-git-send-email-pramod.gurav.etc@gmail.com \
--to=pramod.gurav.etc@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=inux-pm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®