From: Vincent Heuken <me@vincentheuken.com>
To: perex@perex.cz, tiwai@suse.de
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Vincent Heuken <me@vincentheuken.com>
Subject: [PATCH] Sound: Core: fixed assignment in if condition style error in hwdep.c
Date: Fri, 20 Jun 2014 08:50:35 -0700 [thread overview]
Message-ID: <1403279435-31231-1-git-send-email-me@vincentheuken.com> (raw)
This is a patch to the hwdep.c file that fixes one instance of
the following error:
ERROR: do not use assignment in if condition
It also, incidentally, fixes one instance of the following warning:
WARNING: line over 80 characters
Signed-off-by: Vincent Heuken <me@vincentheuken.com>
---
sound/core/hwdep.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
index 69459e5..42d8324 100644
--- a/sound/core/hwdep.c
+++ b/sound/core/hwdep.c
@@ -527,7 +527,9 @@ static void __init snd_hwdep_proc_init(void)
{
struct snd_info_entry *entry;
- if ((entry = snd_info_create_module_entry(THIS_MODULE, "hwdep", NULL)) != NULL) {
+ entry = snd_info_create_module_entry(THIS_MODULE, "hwdep", NULL);
+
+ if (entry != NULL) {
entry->c.text.read = snd_hwdep_proc_read;
if (snd_info_register(entry) < 0) {
snd_info_free_entry(entry);
--
2.0.0
next reply other threads:[~2014-06-20 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 15:50 Vincent Heuken [this message]
2014-06-23 16:12 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403279435-31231-1-git-send-email-me@vincentheuken.com \
--to=me@vincentheuken.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®