From: Oliver Neukum <oneukum@suse.de>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Emil Goode <emilgoode@gmail.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/net/usb/asix_devices.c: inline ax88772_unbind
Date: Mon, 23 Jun 2014 08:58:17 +0200 [thread overview]
Message-ID: <1403506697.10017.3.camel@linux-fkkt.site> (raw)
In-Reply-To: <1403296852-6376-1-git-send-email-fabf@skynet.be>
On Fri, 2014-06-20 at 22:40 +0200, Fabian Frederick wrote:
> inline this one line function used in driver_info structure
That precisely is this the reason not to inline this.
It is used as a function pointer. gcc must generate
a non-inlined version of the function.
Your patch has zero effect and suggests something that is
actually wrong.
Regards
Oliver
prev parent reply other threads:[~2014-06-23 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 20:40 Fabian Frederick
2014-06-21 0:09 ` Sergei Shtylyov
2014-06-23 6:58 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403506697.10017.3.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=davem@davemloft.net \
--cc=emilgoode@gmail.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®