mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: linux-kernel@vger.kernel.org
Cc: jirislaby@gmail.com, Vojtech Pavlik <vojtech@suse.cz>,
	Jiri Kosina <jkosina@suse.cz>, Jiri Slaby <jslaby@suse.cz>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>
Subject: [PATCH 14/21] kgr: add procfs interface for per-process 'kgr_in_progress'
Date: Mon, 23 Jun 2014 15:29:28 +0200	[thread overview]
Message-ID: <1403530175-29217-14-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1403530175-29217-1-git-send-email-jslaby@suse.cz>

From: Jiri Kosina <jkosina@suse.cz>

Instead of flooding dmesg with data about tasks which haven't yet been
migrated to the "new universe", create a 'kgr_in_progress' in
/proc/<pid>/ so that it's possible to easily script the checks/actions
in userspace.

js: use the kgr helper

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jiri Slaby <jslaby@suse.cz> [simplification]
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
---
 fs/proc/base.c  | 11 +++++++++++
 kernel/kgraft.c |  3 +--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 2d696b0c93bf..60f7b1ce5d1c 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -87,6 +87,7 @@
 #include <linux/slab.h>
 #include <linux/flex_array.h>
 #include <linux/posix-timers.h>
+#include <linux/kgraft.h>
 #ifdef CONFIG_HARDWALL
 #include <asm/hardwall.h>
 #endif
@@ -2106,6 +2107,13 @@ static const struct file_operations proc_timers_operations = {
 };
 #endif /* CONFIG_CHECKPOINT_RESTORE */
 
+#if IS_ENABLED(CONFIG_KGRAFT)
+static int proc_pid_kgr_in_progress(struct task_struct *task, char *buffer)
+{
+	return sprintf(buffer, "%d\n", kgr_task_in_progress(task));
+}
+#endif /* IS_ENABLED(CONFIG_KGRAFT) */
+
 static int proc_pident_instantiate(struct inode *dir,
 	struct dentry *dentry, struct task_struct *task, const void *ptr)
 {
@@ -2638,6 +2646,9 @@ static const struct pid_entry tgid_base_stuff[] = {
 #ifdef CONFIG_CHECKPOINT_RESTORE
 	REG("timers",	  S_IRUGO, proc_timers_operations),
 #endif
+#if IS_ENABLED(CONFIG_KGRAFT)
+	INF("kgr_in_progress",	S_IRUSR, proc_pid_kgr_in_progress),
+#endif
 };
 
 static int proc_tgid_base_readdir(struct file *file, struct dir_context *ctx)
diff --git a/kernel/kgraft.c b/kernel/kgraft.c
index ce733f3f2640..0d04f1cbcd4a 100644
--- a/kernel/kgraft.c
+++ b/kernel/kgraft.c
@@ -77,9 +77,8 @@ static bool kgr_still_patching(void)
 	read_lock(&tasklist_lock);
 	for_each_process(p) {
 		if (kgr_task_in_progress(p)) {
-			pr_info("pid %d (%s) still in kernel after timeout\n",
-					p->pid, p->comm);
 			failed = true;
+			break;
 		}
 	}
 	read_unlock(&tasklist_lock);
-- 
2.0.0


  parent reply	other threads:[~2014-06-23 13:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 13:29 [PATCH 01/21] ftrace: Add function to find fentry of function Jiri Slaby
2014-06-23 13:29 ` [PATCH 02/21] ftrace: Make ftrace_is_dead available globally Jiri Slaby
2014-06-23 13:29 ` [PATCH 03/21] kgr: initial code Jiri Slaby
2014-06-23 13:29 ` [PATCH 04/21] kgr: add testing kgraft patch Jiri Slaby
2014-06-23 13:29 ` [PATCH 05/21] kgr: update Kconfig documentation Jiri Slaby
2014-06-23 13:29 ` [PATCH 06/21] kgr: add Documentation Jiri Slaby
2014-06-23 13:29 ` [PATCH 07/21] kgr: trigger the first check earlier Jiri Slaby
2014-06-23 13:29 ` [PATCH 08/21] kgr: sched.h, introduce kgr_task_safe helper Jiri Slaby
2014-06-23 13:29 ` [PATCH 09/21] kgr: mark task_safe in some kthreads Jiri Slaby
2014-06-23 13:29 ` [PATCH 10/21] kgr: kthreads support Jiri Slaby
2014-06-23 13:29 ` [PATCH 11/21] kgr: handle irqs Jiri Slaby
2014-06-23 13:29 ` [PATCH 12/21] kgr: add MAINTAINERS entry Jiri Slaby
2014-06-23 13:29 ` [PATCH 13/21] kgr: x86: refuse to build without fentry support Jiri Slaby
2014-06-23 13:29 ` Jiri Slaby [this message]
2014-06-23 13:29 ` [PATCH 15/21] kgr: make a per-process 'in progress' flag a single bit Jiri Slaby
2014-06-23 13:29 ` [PATCH 16/21] kgr: add support for missing functions Jiri Slaby
2014-06-23 13:29 ` [PATCH 17/21] kgr: exercise non-present function Jiri Slaby
2014-06-23 13:29 ` [PATCH 18/21] kgr: fix race of stub and patching Jiri Slaby
2014-06-23 13:29 ` [PATCH 19/21] kgr: expose global 'in_progress' state through procfs Jiri Slaby
2014-06-23 13:29 ` [PATCH 20/21] kgr: rephrase the "kGraft failed" message Jiri Slaby
2014-06-23 13:29 ` [PATCH 21/21] kgr: x86: optimize handling of CPU-bound tasks Jiri Slaby
2014-06-23 13:51 ` [PATCH 00/21] kGraft Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403530175-29217-14-git-send-email-jslaby@suse.cz \
    --to=jslaby@suse.cz \
    --cc=fweisbec@gmail.com \
    --cc=jirislaby@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®